[Newton] During major-upgrade-pacemaker we should also enable the services migrated to systemd

[Michele Baldessari]

During the "major-upgrade-pacemaker" step we basically do the following:
1) For all the OSP9-mitaka pacemaker services we first delete any constraints and then disable and then delete the pacemaker resource from the cluster CIB
https://github.com/openstack/tripleo-heat-templates/blob/stable/newton/extraconfig/tasks/major_upgrade_pacemaker_migrations.sh#L67-L99 [A]
2) We then update all packages via yum
3) Then we start all the services.

In 3) we do this:
for service in $services; do
    manage_systemd_service start "${service%%-clone}"
    check_resource_systemd "${service%%-clone}" started 600
done

We also want to explicitly enable the service so that if a reboot happens before the convergence step the controller node will come up with the services being enabled.

[Michele Baldessari (michele)]

This was first observed in https://bugzilla.redhat.com/show_bug.cgi?id=1416073

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/451512

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/451512
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a7e6dcdb552fb93d84fbd06ba5bb3543ec3c1c62
Submitter: Jenkins
Branch: stable/newton

commit a7e6dcdb552fb93d84fbd06ba5bb3543ec3c1c62
Author: Michele Baldessari <email address hidden>
Date: Wed Mar 29 20:45:43 2017 +0200

    [Newton-only] Enable services in the major-upgrade-pacemaker step

    During the "major-upgrade-pacemaker" step we basically do the following:
    1) For all the OSP9-mitaka pacemaker services we first delete any
    constraints and then disable and then delete the pacemaker resource from
    the cluster CIB https://github.com/openstack/tripleo-heat-templates/blob/stable/newton/extraconfig/tasks/major_upgrade_pacemaker_migrations.sh#L67-L99
    2) We then update all packages via yum
    3) Then we start all the services.

    In 3) we do this:
    for service in $services; do
        manage_systemd_service start "${service%%-clone}"
        check_resource_systemd "${service%%-clone}" started 600
    done

    We also want to explicitly enable the service so that if a reboot
    happens before the convergence step the controller node will come up
    with the services being enabled.

    Change-Id: Ie163e5f1d24b23b46092a9a3cb844fcb4e810f7b
    Closes-Bug: #1677346

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.0 release.