command 'freezer action-create --file' can create action with invalid file
Bug #1677188 reported by
jiaopengju
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Backup/Restore and DR (Freezer) |
Fix Released
|
Undecided
|
jiaopengju |
Bug Description
First, I create a file named action-backup-vol with contents as below:
{
"action" : "backup",
"mode": "cinder",
"cinder-vol-id" : "8f00b5c5-
"container" : "volumebackupco
"backup_name" : "project_
}
freezer action-create --file action-backup-vol
It shows I have created the action correctly.
But when I use freezer action-list to list the actions I have created, it will show default values but not the real value.
I think we should add a json validation before create action in freezer-api.
Changed in freezer: | |
assignee: | nobody → jiaopengju (pj-jiao) |
Changed in freezer: | |
status: | New → In Progress |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/451648 /git.openstack. org/cgit/ openstack/ freezer- api/commit/ ?id=8c99dcefb73 b13c524b0cc6769 7eed56363c81c2
Committed: https:/
Submitter: Jenkins
Branch: master
commit 8c99dcefb73b13c 524b0cc67697eed 56363c81c2
Author: Pengju Jiao <email address hidden>
Date: Thu Mar 30 12:57:52 2017 +0800
Add 'freezer_action' to action schema
Currently we can create a new action with invalid
action file that has no 'freezer_action' option
correctly, but when we get the action info with
'freezer action-list', it will show the default
and invalid values. So this patch add 'freezer-action'
to the json validation.
Depends-On: I45c419852b177e 1d1b067bb5b7f25 a60c6c88f7f f585dfadb0761f7 11f702aa1ab
Change-Id: Id4619ae625865d
Closes-Bug: #1677188