tripleo-common cannot be built in CI due to pull-puppet-modules

[Alex Schultz]

I'm seeing CI failures when a change depends on a change for tripleo-ci where the rpm package build is failing and the logs are pointing to pull-puppet-modules being installed but not unpackaged

http://logs.openstack.org/62/418562/9/check/gate-tripleo-ci-centos-7-undercloud-upgrades-nv/2510e4d/console.html#_2017-03-28_22_50_20_607757

http://paste.openstack.org/show/604584/

https://github.com/rdo-packages/tripleo-common-distgit/commit/376c7f75627d100262b9674fa65dba966d84ff13

[Alex Schultz (alex-schultz)]

Seems like we're picking up ocata package specs instead of master. possibly because of the centos7-ocata being passed to build_rpm.sh http://logs.openstack.org/62/418562/9/check/gate-tripleo-ci-centos-7-undercloud-upgrades-nv/2510e4d/console.html#_2017-03-28_22_51_53_564807

[Martin André (mandre)]

It's building rpm for ocata because it's an upgrade job:

https://github.com/openstack-infra/tripleo-ci/blob/26c2aae8c27ebc77b5b1654d5465685c5c52abf1/toci_gate_test-orig.sh#L196

https://github.com/openstack-infra/tripleo-ci/blob/26c2aae8c27ebc77b5b1654d5465685c5c52abf1/scripts/tripleo.sh#L114

https://github.com/openstack-infra/tripleo-ci/blob/26c2aae8c27ebc77b5b1654d5465685c5c52abf1/scripts/tripleo.sh#L461

We need https://review.openstack.org/#/c/446511/ and https://review.rdoproject.org/r/#/c/6029/ that we'll have to ninja merge to workaround a chicken & egg issue.

[Alan Pevec (apevec)]

So this a mixup between REVIEW_RELEASE and STABLE_RELEASE, and upgrade job ends up building with STABLE_RELEASE when it should be REVIEW_RELEASE?

[Alfredo Moralejo (amoralej)]

https://review.openstack.org/#/c/443216/ broke initial patch, i'm looking for the best fix.

[Alfredo Moralejo (amoralej)]

https://review.openstack.org/#/c/451265/ should fix it

[Alfredo Moralejo (amoralej)]

This has been fixed by https://review.openstack.org/#/c/451265/ , I'm not sure why the status of the LP has not been updated.

Logs of successful run after the patch:

http://logs.openstack.org/62/418562/9/check/gate-tripleo-ci-centos-7-undercloud-upgrades-nv/0c4ef57/console.html#_2017-03-29_21_49_44_054284