Setting storage.zfs_pool_name is deprecated in favor of storage pool configuration

[Ryan Beisner]

The lxd charm fails on Zesty (currently in dev) with:

error: Setting the key "storage.zfs_pool_name" is deprecated in favor of storage pool configuration

2017-03-28 04:28:28 INFO config-changed error: Setting the key "storage.zfs_pool_name" is deprecated in favor of storage pool configuration.
2017-03-28 04:28:28 INFO config-changed Traceback (most recent call last):
2017-03-28 04:28:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-0/charm/hooks/config-changed", line 140, in <module>
2017-03-28 04:28:28 INFO config-changed main()
2017-03-28 04:28:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-0/charm/hooks/config-changed", line 134, in main
2017-03-28 04:28:28 INFO config-changed hooks.execute(sys.argv)
2017-03-28 04:28:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-0/charm/hooks/charmhelpers/core/hookenv.py", line 731, in execute
2017-03-28 04:28:28 INFO config-changed self._hooks[hook_name]()
2017-03-28 04:28:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-0/charm/hooks/config-changed", line 77, in config_changed
2017-03-28 04:28:28 INFO config-changed configure_lxd_block()
2017-03-28 04:28:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-0/charm/hooks/lxd_utils.py", line 274, in configure_lxd_block
2017-03-28 04:28:28 INFO config-changed check_call(cmd)
2017-03-28 04:28:28 INFO config-changed File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
2017-03-28 04:28:28 INFO config-changed raise CalledProcessError(retcode, cmd)
2017-03-28 04:28:28 INFO config-changed subprocess.CalledProcessError: Command '['lxc', 'config', 'set', 'storage.zfs_pool_name', 'lxd']' returned non-zero exit status 1
2017-03-28 04:28:28 INFO juju.worker.uniter.context context.go:579 handling reboot
2017-03-28 04:28:28 ERROR juju.worker.uniter.operation runhook.go:107 hook "config-changed" failed: exit status 1

[Ryan Beisner (1chb1n)]

https://review.openstack.org/#/c/458763/

[Ryan Beisner (1chb1n)]

https://review.openstack.org/#/q/topic:bug/1676742

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/458763
Committed: https://git.openstack.org/cgit/openstack/charm-lxd/commit/?id=6df877339c55435a3e87774d7232f4cc0f51bd35
Submitter: Jenkins
Branch: master

commit 6df877339c55435a3e87774d7232f4cc0f51bd35
Author: Chris MacNaughton <email address hidden>
Date: Fri Apr 21 10:15:14 2017 +0200

    Migrate to LXD storage pools

    We need to continue with the previous style of managing storage
    until zesty or a specified -updates channel LXD

    This additionally reinforces our suggested deployment with ZFS
    for a deployment, rather than using LVM as the defualt in
    testing.

    Closes-Bug: 1676742
    Related-Bug: 1573681
    Depends-On: I5c38766c4be66d63ef4a07eccc780fcab5973d49
    Change-Id: I3ddbd11382c34ff9200e721fa3c90fe67bdce534