add-cloud vsphere prompts for vCenter and datacenter

Bug #1676539 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-ci-tools
Fix Released
Critical
Curtis Hovey

Bug Description

As seen at
    http://reports.vapour.ws/releases/issue/58d95a66749a563594e7f18c

Several tests are failing because of
    https://github.com/juju/juju/commit/f96673fb1495f16697894766e32b7ecb1405a29e

    you should be asked for "the vCenter address or URL" (endpoint) and "datacenter name" (region)

Enter the vCenter address or URL: ERROR:root:Adding cloud failed: pexpect session timed out

The test needs to change. We need to support juju 2.1, so the expect rules need to OR old and new prompt.

Related branches

Revision history for this message
Curtis Hovey (sinzui) wrote :

ModelClient.add_cloud_interactive()'s vsphere block could expect
    "Enter the vCenter address or URL:|Enter the API endpoint url for the cloud:"
and
    "Enter region name:|Enter datacenter name:"
and other prompts
...
            if cloud['type'] == 'vsphere':
                child.expect('Enter the API endpoint url for the cloud:')
                child.sendline(cloud['endpoint'])
                for num, (name, values) in enumerate(cloud['regions'].items()):
                    child.expect("(Enter region name:)|"
                                 "(Can't validate endpoint)")
                    if child.match.group(2) is not None:
                        raise InvalidEndpoint()
                    child.sendline(name)
                    child.expect('Enter another region\? \(Y/n\):')
                    if num + 1 < len(cloud['regions']):
                        child.sendline('y')
                    else:
                        child.sendline('n')

Revision history for this message
Curtis Hovey (sinzui) wrote :

Or
   (API endpoint url for the cloud|vCenter address or URL)
   (region|datacenter)
   (regions|datacenters)

s. (salamcainc)
Changed in juju-ci-tools:
assignee: nobody → s. (salamcainc)
status: Triaged → Fix Released
Revision history for this message
Anastasia (anastasia-macmood) wrote :

@s. (salamcainc),

Please clarify based on what change the status of this bug was moved to 'Fix Released'?...

Changed in juju-ci-tools:
status: Fix Released → Triaged
assignee: s. (salamcainc) → nobody
Revision history for this message
Curtis Hovey (sinzui) wrote :

This bug is not fixed released or even fixed. I am taking this bug and will get the fix released today.

Changed in juju-ci-tools:
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in juju-ci-tools:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.