Ironic conductor fails to start (sudo modprobe iscsi_tcp)

[Dan Prince]

It appears that since https://github.com/openstack/kolla/commit/05c0d6998bdda155c925d563b75ac353303f93ff my Ironic conductor no longer starts. This is because when built as a binary container the new kolla_ironic_sudoers is missing. (it is only included in the source version?)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/450274

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/450274
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=8b101b28a1040fd6b4753c09364106274d7e6e09
Submitter: Jenkins
Branch: master

commit 8b101b28a1040fd6b4753c09364106274d7e6e09
Author: Dan Prince <email address hidden>
Date: Mon Mar 27 10:48:19 2017 -0400

    Add ironic sudoers file to binary packages as well

    When built as binary packages Ironic conductor would
    fail to start due to a new 'sudo modprobe iscsi_tcp' command
    added in 05c0d6998bdda155c925d563b75ac353303f93ff

    Change-Id: I74ebbc2ec612e1068ac82225dc79e9ee0b6c23f4
    Closes-bug: #1676466

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/452207

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452207
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=1c3336c8c9c1a77964041730973b4839c9a4c441
Submitter: Jenkins
Branch: master

commit 1c3336c8c9c1a77964041730973b4839c9a4c441
Author: Mark Goddard <email address hidden>
Date: Fri Mar 31 14:32:43 2017 +0100

    Use separate sudoers for ironic conductor modprobe

    The original fix (8b101b28a1040fd6b4753c09364106274d7e6e09) for bug
    1676466 added unnecessary entries to the sudoers file in the
    ironic-base image. These included a rootwrap entry pointing to the
    virtualenv used by source type images (not present in binary type
    images) and a modprobe iscsi_tcp which is only required by the
    ironic-conductor image.

    This change adds a single sudoers file for the iscsi_tcp modprobe
    to the ironic-conductor image and reverts to the common pattern of
    adding a sudoers file to ironic-base only for source type images.

    Change-Id: I89f1c4bd741de9ba184f14fcbcb708636616e420
    Closes-bug: #1678143
    Related-bug: #1676466
    Related-bug: #1667864

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla 5.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ocata
Review: https://review.openstack.org/557986

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/557986
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=c67d4f9fb4a4522e8fa36871d81645cf0f6bedfd
Submitter: Zuul
Branch: stable/ocata

commit c67d4f9fb4a4522e8fa36871d81645cf0f6bedfd
Author: Mark Goddard <email address hidden>
Date: Fri Mar 31 14:32:43 2017 +0100

    Use separate sudoers for ironic conductor modprobe

    The original fix (8b101b28a1040fd6b4753c09364106274d7e6e09) for bug
    1676466 added unnecessary entries to the sudoers file in the
    ironic-base image. These included a rootwrap entry pointing to the
    virtualenv used by source type images (not present in binary type
    images) and a modprobe iscsi_tcp which is only required by the
    ironic-conductor image.

    This change adds a single sudoers file for the iscsi_tcp modprobe
    to the ironic-conductor image and reverts to the common pattern of
    adding a sudoers file to ironic-base only for source type images.

    Change-Id: I89f1c4bd741de9ba184f14fcbcb708636616e420
    Closes-bug: #1678143
    Related-bug: #1676466
    Related-bug: #1667864
    (cherry picked from commit 1c3336c8c9c1a77964041730973b4839c9a4c441)