Mir

[regression] Mir is assigning the first output ID = 0 (== mir_display_output_id_invalid)

Bug #1675331 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Mir development team
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Mir is assigning the first output ID = 0 (== mir_display_output_id_invalid):

[2017-03-23 17:22:28.936000] mirserver: Initial display configuration:
[2017-03-23 17:22:28.936026] mirserver: Output 0: HDMI-A disconnected
[2017-03-23 17:22:28.936030] mirserver: Output 1: VGA disconnected
[2017-03-23 17:22:28.936032] mirserver: Output 2: DisplayPort disconnected
[2017-03-23 17:22:28.936035] mirserver: Output 3: HDMI-A disconnected
[2017-03-23 17:22:28.936039] mirserver: Output 4: DisplayPort connected, used

However we have already declared that:
include/client/mir_toolkit/client_types.h:enum { mir_display_output_id_invalid = 0 };

Related branches

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Bisected. It change came from:

------------------------------------------------------------
revno: 4103 [merge]
author: Christopher James Halse Rogers <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Wed 2017-03-22 07:01:56 +0000
message:
  Clarify KMS display configuration responsibilities.

  This moves responsibility for converting between KMS hardware state and Mir DisplayOutputConfiguration to KMSOutput, moves DisplayConfigurationOutputId → KMSOutput lookup into KMSDisplayConfiguration, and makes KMSOutputContainer responsible for maintaining the set of KMSOutput as they appear and disappear.

  Approved by mir-ci-bot, Kevin DuBois, Alan Griffiths.
------------------------------------------------------------

Changed in mir:
status: New → Triaged
Changed in mir:
assignee: nobody → Mir development team (mir-team)
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 1.0.0

Changed in mir:
status: Triaged → Fix Committed
Changed in mir (Ubuntu):
status: New → Invalid
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (8.3 KiB)

This bug was fixed in the package mir - 0.27.0+17.10.20170630-0ubuntu1

---------------
mir (0.27.0+17.10.20170630-0ubuntu1) artful; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.27.0 (https://launchpad.net/mir/+milestone/0.27.0)
    - ABI summary:
      . mirclient ABI unchanged at 9
      . mirserver ABI bumped to 44
      . mircommon ABI unchanged at 7
      . mirplatform ABI bumped to 61
      . mirprotobuf ABI unchanged at 3
      . mirplatformgraphics ABI bumped to 13
      . mirclientplatform ABI unchanged at 5
      . mirinputplatform ABI bumped to 7
      . mircore ABI unchanged at 1
    - Enhancements:
      . Mostly groundwork required to support major enhancements coming in
        future Mir versions.
      . Removed android-input and eliminated the entire "3rd_party/" subtree.
        Now the Mir source tree contains original code only.
      . Added mir_prompt_session_new_fds_for_prompt_providers_sync API.
      . mirout: Added load and save options for keeping display configs
        on disk.
      . mirout: Added "--" support for applying configuration changes under
        Unity8.
      . Fixed failure of DRM hardware cursor {hide(); show(image);}
      . Added server option: "--cursor software" (MIR_SERVER_CURSOR=software)
      . Added letterboxing/black bars support to the GL renderer in preparation
        for generic output cloning.
      . Added client API for getting the logical size of an output.
      . Migrated MirCookie to use SHA-256.
      . Ensure RealKMSOutputConfiguration stays in sync with actual hardware
        state.
      . Added support for drag-and-drop.
      . Lots of other client API enhancements.
      . Minor clean-ups, optimizations and dead code removal.
      . Added support for building on Ubuntu 17.10 artful.
      . Update example code to use undeprecated API.
      . mesa-kms: Support hardware cursors in hybrid setups.
      . Rework and publish the graphics platform APIs
    - Bugs fixed:
      . [enhancement] Make able to get version information from client /
        server APIs (LP: #1195540)
      . Touch screen coordinates don't rotate with the screen (LP: #1349660)
      . Subpixel order not included in Mir display information (LP: #1393578)
      . [enhancement] Missing client API for relative surface movement (e.g.
        dragging client-decorated windows) (LP: #1420334) . Mir does not reset
        key states when paused or resumed (modifiers get stuck after VT
        switching) (LP: #1536279)
      . NBS never uses mc::MultiMonitorMode::single_monitor_fast, even when
        only a single monitor is plugged in (LP: #1561418)
      . Inconsistent behaviour of Num Lock (LP: #1588237)
      . A scaled (not panned or clipped) mirror/clone mode is desired
        (LP: #1639226)
      . Rotating an output left or right without restarting the
        compositor distorts the image (LP: #1643488)
      . support display scaling slider in unity8 (LP: #1645372)
      . [ FAILED ] NestedInputWithMouse.mouse_pointer_coordinates_in_nested_
        server_are_accumulated (LP: #1646375)
      . [ FAILED ] NestedInputWithMouse.mouse_pointer_position_is_in_sync_with_
        ho...

Read more...

Changed in mir (Ubuntu):
status: Invalid → Fix Released
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.