devstack transition to new neutron variable breaks bgpvpn

[Thomas Morin]

http://logs.openstack.org/85/395585/3/check/gate-tempest-dsvm-networking-bgpvpn-bagpipe-ubuntu-xenial/feab7f0/logs/devstacklog.txt.gz#_2017-03-21_14_56_29_670

A devstack plugin using libs in neutron devstack plugin (e.g. lib/l2_agent) will break because only
the Q_ variables are defined an the NEUTRON_ .

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/448583

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/448583
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dd882bbc57e74e967047016d9f43735d3bfbb368
Submitter: Jenkins
Branch: master

commit dd882bbc57e74e967047016d9f43735d3bfbb368
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Mar 21 08:30:15 2017 +0000

    Move NEUTRON_* definitions from plugin.sh into settings file

    If devstack triggers a plugin that directly imports from devstack/lib/*
    before triggering neutron's plugin.sh, NEUTRON_* variables that are used
    in some devstack/lib/* files may not be set.

    The ``settings`` file is sourced by devstack for all repos before any of
    plugins enabled in the environment is triggered, and so moving NEUTRON_*
    definitions there should guarantee for us that the variables are set
    when the first enabled plugin is executed.

    Since Q_PLUGIN_CONF_PATH and Q_PLUGIN_CONF_FILE are defined in
    lib/neutron_plugins/ml2:neutron_plugin_configure_common, and we want to
    avoid triggering that code from the plugin, we need to duplicate values
    for NEUTRON_CORE_PLUGIN_CONF_PATH and NEUTRON_CORE_PLUGIN_CONF from
    there.

    Closes-Bug: #1675022
    Change-Id: Ib65d3615fba270c2fd6c116218bbb95a29f56aa6

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.