nova-compute service unexpectedly launched on a controller

[Georgy Dyuldin]

Detailed bug description:
 After deploy MOS 10.0 #1493, #1497 with Nova Ceph RBD enabled nova-compute service is launched on one of the controllers. With Cinder LVM nova-compute service only launched on computes.

[root@nailgun ~]# for i in {1..6}; do echo "node-$i"; ssh node-$i 'hiera roles; ps aux | grep nova-compute'; echo ''; done
node-1
["primary-controller",
 "primary-database",
 "primary-keystone",
 "primary-neutron",
 "primary-rabbitmq"]
root 30246 0.0 0.0 11236 2920 ? Ss 06:39 0:00 bash -c hiera roles; ps aux | grep nova-compute
root 30250 0.0 0.0 12944 936 ? S 06:39 0:00 grep nova-compute

node-2
["controller", "database", "keystone", "neutron", "rabbitmq"]
root 23755 0.0 0.0 11236 2924 ? Ss 06:39 0:00 bash -c hiera roles; ps aux | grep nova-compute
root 23759 0.0 0.0 12944 1016 ? S 06:39 0:00 grep nova-compute

node-3
["ceph-osd", "compute"]
nova 11137 0.3 1.6 1934644 172756 ? Ssl 05:04 0:20 /usr/bin/python /usr/bin/nova-compute --config-file=/etc/nova/nova-compute.conf --config-file=/etc/nova/nova.conf --log-file=/var/log/nova/nova-compute.log
root 15469 0.0 0.2 82164 26104 ? S 06:33 0:00 /usr/bin/python2.7 /usr/bin/privsep-helper --config-file /etc/nova/nova-compute.conf --config-file /etc/nova/nova.conf --privsep_context vif_plug_ovs.privsep.vif_plug --privsep_sock_path /tmp/tmpmSmoZu/privsep.sock
root 24580 0.0 0.0 11236 2928 ? Ss 06:39 0:00 bash -c hiera roles; ps aux | grep nova-compute
root 24584 0.0 0.0 12944 1032 ? R 06:39 0:00 grep nova-compute

node-4
["controller", "database", "keystone", "neutron", "rabbitmq"]
nova 14694 7.3 1.3 281500 137004 ? Ss 06:38 0:04 /usr/bin/python /usr/bin/nova-compute --config-file=/etc/nova/nova-compute.conf --config-file=/etc/nova/nova.conf --log-file=/var/log/nova/nova-compute.log
nova 15423 0.2 1.3 281508 136656 ? S 04:15 0:24 /usr/bin/python /usr/bin/nova-compute --config-file=/etc/nova/nova.conf --config-file=/etc/nova/nova-compute.conf
root 18260 0.0 0.0 11236 3000 ? Ss 06:39 0:00 bash -c hiera roles; ps aux | grep nova-compute
root 18264 0.0 0.0 12944 1088 ? S 06:39 0:00 grep nova-compute

node-5
["ceph-osd", "compute"]
root 13452 0.0 0.0 11236 3004 ? Ss 06:39 0:00 bash -c hiera roles; ps aux | grep nova-compute
root 13456 0.0 0.0 12944 980 ? S 06:39 0:00 grep nova-compute
nova 18995 1.1 1.7 1937980 176792 ? Ssl 05:04 1:08 /usr/bin/python /usr/bin/nova-compute --config-file=/etc/nova/nova-compute.conf --config-file=/etc/nova/nova.conf --log-file=/var/log/nova/nova-compute.log
root 30670 0.0 0.2 82164 26216 ? S 05:20 0:01 /usr/bin/python2.7 /usr/bin/privsep-helper --config-file /etc/nova/nova-compute.conf --config-file /etc/nova/nova.conf --privsep_context vif_plug_ovs.privsep.vif_plug --privsep_sock_path /tmp/tmpd46EDl/privsep.sock

node-6
["ironic"]
root 30716 0.0 0.0 11236 3076 ? Ss 06:39 0:00 bash -c hiera roles; ps aux | grep nova-compute
root 30720 0.0 0.0 12944 1016 ? S 06:39 0:00 grep nova-compute

In example above nova-compute is launched on node-4 (controller node)

Steps to reproduce:
 Deploy MOS 10.0 with 3 controllers, 2 computes+ceph-osd nodes. Choose Ceph RBD as storage for Nova.

[Oleksiy Molchanov (omolchanov)]

2017-03-20 23:18:30 +0000 /Stage[main]/Main/Exec[ironic_upload_images_shell]/returns (err): change from notrun to 0 failed: /bin/bash "/etc/puppet/shell_manifests/ironic_upload_images_command.sh" returned
1 instead of one of [0]

Ironic bootstrap image build was not triggered.

[Oleksiy Molchanov (omolchanov)]

When deployed with ironic it is pacemaker service, that should run only on one controller.

p_nova_compute_ironic (ocf::fuel:nova-compute): Started node-4.test.domain.local