Recently introduced retry function suffers from several issues.

[VIncent S. Cojot]

There were multiple issues in retry() in rhel-registration:
 - There was no need for it to be recursive (local variables
   got overwritten)
 - There was no delay between multiple attempts, leading to faster but
   more frequent failures.
 - The max number of attempts was set too low for some environements.

This is fixed by: https://review.openstack.org/#/c/445045

It would be very useful to backport this as far as stable/newton.
Thank you,
Vincent

[Michael Turek (mjturek)]

Seems unrelated to Ironic, switching over to tripleo bug. Let me know if you disagree.

[VIncent S. Cojot (vincent-m)]

Sorry about that, Thanks Michael.

[Emilien Macchi (emilienm)]

Vincent, please backport the fixes to stable/ocata and stable/newton and add in the commit message (at the end): Closes-Bug: #1674358

Thanks

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/447671

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/447671
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1652f1b2518a60bfbfbd1f3f3714e8c22d4e17e5
Submitter: Jenkins
Branch: stable/ocata

commit 1652f1b2518a60bfbfbd1f3f3714e8c22d4e17e5
Author: Vincent S. Cojot <email address hidden>
Date: Mon Mar 13 14:39:16 2017 -0400

    Fixes multiple issues with retry function in rhel-registration.

    There were multiple issues in retry() in rhel-registration:
     - There was no need for it to be recursive (local variables
       got overwritten)
     - There was no delay between multiple attempts, leading to faster but
       more frequent failures.
     - The max number of attempts was set too low for some environements.

    With this patch, rhel-registration now works more reliably with slow-links
    for portal registration and does not attempt to DDos the portal or your
    satellite server.

    Closes-Bug: #1674358
    Change-Id: I594d3c94867b45a7a58766dbcc66edead78d6a4e
    (cherry picked from commit 038eae089130bc3a814897c0e282223de16f4658)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.1.0 release.

[Emilien Macchi (emilienm)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[Emilien Macchi (emilienm)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (FUTURE, PIKE, QUEENS, ROCKY, STEIN).
  Valid example: CONFIRMED FOR: FUTURE