code comments incorrectness
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
Sean Dague |
Bug Description
I am running OpenStack Mitaka on CentOS7.1 with VMware vSphere 5.5 Enterprise Plus.
In function get_datastore() of nova/virt/
......
datastore_ret = session.
# If there are no hosts in the cluster then an empty string is returned.
if not datastore_ret:
raise exception.
......
According to context, I think this comments are incorrectness:
1) We get datastore objects, not hosts object.
2) If there are no datastores in the cluster then raise exception, not return an empty string.
Changed in nova: | |
assignee: | nobody → Zhou Jianming (zhoujm-cri) |
Changed in nova: | |
status: | New → In Progress |
importance: | Undecided → Low |
Changed in nova: | |
assignee: | Zhou Jianming (zhoujm-cri) → Sean Dague (sdague) |
Reviewed: https:/ /review. openstack. org/449416 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=65a2c63acf6 b5e9d38ef3caa29 28eebcc62486a2
Committed: https:/
Submitter: Jenkins
Branch: master
commit 65a2c63acf6b5e9 d38ef3caa2928ee bcc62486a2
Author: Zhou Jianming <email address hidden>
Date: Thu Mar 23 11:12:47 2017 +0800
code comments incorrectness
Closes-Bug: #1674259
Change-Id: I5318bc274832b3 16c017df087f06b b4254a270e1