code comments incorrectness

Bug #1674259 reported by Zhou Jianming
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Sean Dague

Bug Description

I am running OpenStack Mitaka on CentOS7.1 with VMware vSphere 5.5 Enterprise Plus.
In function get_datastore() of nova/virt/vmwareapi/ds_utils.py file, the following code comments:
      ......
      datastore_ret = session._call_method(vutil,
                                           "get_object_property",
                                           object,
                                           "datastore")
      # If there are no hosts in the cluster then an empty string is returned.
      if not datastore_ret:
          raise exception.DatastoreNotFound()

      ......

According to context, I think this comments are incorrectness:
   1) We get datastore objects, not hosts object.
   2) If there are no datastores in the cluster then raise exception, not return an empty string.

Changed in nova:
assignee: nobody → Zhou Jianming (zhoujm-cri)
Changed in nova:
status: New → In Progress
importance: Undecided → Low
Changed in nova:
assignee: Zhou Jianming (zhoujm-cri) → Sean Dague (sdague)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/449416
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=65a2c63acf6b5e9d38ef3caa2928eebcc62486a2
Submitter: Jenkins
Branch: master

commit 65a2c63acf6b5e9d38ef3caa2928eebcc62486a2
Author: Zhou Jianming <email address hidden>
Date: Thu Mar 23 11:12:47 2017 +0800

    code comments incorrectness

    Closes-Bug: #1674259

    Change-Id: I5318bc274832b316c017df087f06bb4254a270e1

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b2

This issue was fixed in the openstack/nova 16.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.