Bad error reporting on InternalError

[clayg]

Bad logging for around InternalError - missing details:

2017-03-05 16:26:39 -07:00 storage01 [local0.err] proxy-server: 500 Internal Server Error:
Traceback (most recent call last):
  File "/opt/swift/lib/python2.7/site-packages/swift3/middleware.py", line 80, in __call__
    resp = self.handle_request(req)
  File "/opt/swift/lib/python2.7/site-packages/swift3/middleware.py", line 107, in handle_request
    res = handler(req)
  File "/opt/swift/lib/python2.7/site-packages/swift3/controllers/obj.py", line 113, in PUT
    resp = req.get_response(self.app)
  File "/opt/swift/lib/python2.7/site-packages/swift3/request.py", line 1179, in get_response
    headers, body, query)
  File "/opt/swift/lib/python2.7/site-packages/swift3/request.py", line 1164, in _get_response
    raise InternalError('unexpected status code %d' % status)
InternalError: 500 Internal Server Error (txn: tx63d01231322248e697587-0058bc9eaa) (client_ip: 127.0.0.1)

What was the unexpected status code!?

In [14]: str(swift3.response.InternalError('the answer is 42'))
Out[14]: '500 Internal Server Error'

[clayg (clay-gerrard)]

I looked at the inheritance of swift3's ErrorResponse [1] and the implementation of swob's HTTPException [2] - I think we can do better than just log the str of the exception in swift3 [3]

1. https://github.com/openstack/swift3/blob/cd094eea4a0da214d11b67ee6371629379afee1f/swift3/response.py#L154
2. https://github.com/openstack/swift/blob/31ccc2740a6c50742f8878fd4816d74c2c1849b0/swift/common/swob.py#L1384
3. https://github.com/openstack/swift3/blob/cd094eea4a0da214d11b67ee6371629379afee1f/swift3/middleware.py#L85