config-changed fails when multiple device names are provided (NotImplemented trace)

[Narinder Gupta]

NotImplementedError('Multiple block devices are not supported.')

config-change fails if we provide the multiple devices for block-devices in bundles. As per comments it should accept the first available device in the list.

Here is the bundle http://paste.ubuntu.com/24185313/

juju log is as follows:

http://paste.ubuntu.com/24185316/

This is using 17.02 version of charms.

---

2017-03-15 22:40:28 INFO config-changed Traceback (most recent call last):
2017-03-15 22:40:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-2/charm/hooks/config-changed", line 140, in <module>
2017-03-15 22:40:28 INFO config-changed main()
2017-03-15 22:40:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-2/charm/hooks/config-changed", line 134, in main
2017-03-15 22:40:28 INFO config-changed hooks.execute(sys.argv)
2017-03-15 22:40:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-2/charm/hooks/charmhelpers/core/hookenv.py", line 731, in execute
2017-03-15 22:40:28 INFO config-changed self._hooks[hook_name]()
2017-03-15 22:40:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-2/charm/hooks/config-changed", line 77, in config_changed
2017-03-15 22:40:28 INFO config-changed configure_lxd_block()
2017-03-15 22:40:28 INFO config-changed File "/var/lib/juju/agents/unit-lxd-2/charm/hooks/lxd_utils.py", line 193, in configure_lxd_block
2017-03-15 22:40:28 INFO config-changed raise NotImplementedError('Multiple block devices are not supported.')

[Narinder Gupta (narindergupta)]

After running juju config lxd block-devices=/dev/sdb deployment resolves the error. But as per readme and comments for block-devices it should not throw error and configures /dev/sdb by default.

[Ryan Beisner (1chb1n)]

It looks like the NotImplemented hook error was introduced with this commit:

https://github.com/openstack/charm-lxd/commit/0e87f8dff4c9aeca1c5f3e9d25c8aa80d4e3d7a6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/446329
Committed: https://git.openstack.org/cgit/openstack/charm-lxd/commit/?id=715251784876a70b4c029914d15d48223808a2f1
Submitter: Jenkins
Branch: master

commit 715251784876a70b4c029914d15d48223808a2f1
Author: Chris MacNaughton <email address hidden>
Date: Thu Mar 16 08:24:19 2017 +0100

    Adhere to the readme

    Currently, providing a list of devices in config will lead
    to an exception, despite the readme calling that out as an
    option. Instead, we will now log a message and continue
    with the behavious documented in the readme.

    Change-Id: Ib5a1d1a0257227e829e433bc61f64ad4cba8052e
    Closes-Bug: 1673277