Greetings,
Now that featureset configurations have merged I see a divergence in how the network-environment settings for network-isolation are set.
Traditionally we have used the pre-deploy.yml in overcloud-deploy to setup the network_isolation_args. [1] The network-isolation.yml file which customizes the settings for the deployment is generated [2]
We now need to be able directly to import settings from tripleo-ci [3], this is fine but we are setting that in a featureset [4] configuration file that is not relevant to users outside of tripleo-ci and will *not* work.
Basically, fs001 will fail for libvirt users.
I'm pretty sure we do not want to maintain to many configuration files and have separate config for libvirt, tripleo-ci etc..etc.
I think we want to change the featureset config to be the following in [5]
network_isolation: true
network_isolation_type: "single-nic-vlan"
and override the settings in the ovb-settings.yml in tripleo-ci only [6]
[1] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/overcloud-deploy/tasks/pre-deploy.yml#L12-L19
[2] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/overcloud-prep-config/tasks/main.yml#L15-L20
https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/overcloud-prep-config/templates/network-environment.yaml.j2
[3] https://github.com/openstack-infra/tripleo-ci/blob/master/test-environments/network-templates/network-environment.yaml
[4] https://github.com/openstack/tripleo-quickstart/blob/master/config/general_config/featureset001.yml#L14-L19
[5] https://github.com/openstack/tripleo-quickstart/blob/master/config/general_config/featureset001.yml#L15-L16
[6] https://github.com/openstack-infra/tripleo-ci/blob/master/scripts/quickstart/ovb-settings.yml#L31-L35
Change abandoned by wes hayutin (<email address hidden>) on branch: master /review. openstack. org/446181
Review: https:/