Disabling satellite repo after registration makes it difficult to update those packages

[Ben Nemec]

Currently the rhel registration script in t-h-t disables the satellite repo after installing the necessary packages from it. This means those packages will not be updated automatically, which is awkward to deal with for deployers.

I believe this behavior is a holdover from the dib registration script, where we don't want to leave any repos enabled after the build is complete because the image may be deployed many times. However, in t-h-t the script is only run at deploy time, so it's okay and desirable to leave the repos enabled.

See also: https://bugzilla.redhat.com/show_bug.cgi?id=1311859

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/446014

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/446014
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=551baca688449f6f7f798577229cae39abbe6107
Submitter: Jenkins
Branch: master

commit 551baca688449f6f7f798577229cae39abbe6107
Author: Ben Nemec <email address hidden>
Date: Wed Mar 15 10:21:43 2017 -0500

    Don't disable satellite repo after registration

    Previously the rhel registration script disabled the satellite repo
    after installing packages from it. This means those packages will
    never be updated, which is not desirable from a long-term
    maintenance perspective.

    I believe this behavior is a holdover from the dib registration
    script, where we don't want to leave repos enabled because the
    image may be deployed many times and each instance needs to be
    re-registered. In t-h-t we don't have that problem because the
    script only runs at deploy time so it's okay and desirable to leave
    the repos enabled.

    Change-Id: I5d760467b458d90d74507a55effc49b71d22eaa3
    Closes-Bug: 1673116

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/495450

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/495452

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/495450
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2321346969e4e5f0b2ba056736dfcf1e005bbcad
Submitter: Jenkins
Branch: stable/ocata

commit 2321346969e4e5f0b2ba056736dfcf1e005bbcad
Author: Ben Nemec <email address hidden>
Date: Wed Mar 15 10:21:43 2017 -0500

    Don't disable satellite repo after registration

    Previously the rhel registration script disabled the satellite repo
    after installing packages from it. This means those packages will
    never be updated, which is not desirable from a long-term
    maintenance perspective.

    I believe this behavior is a holdover from the dib registration
    script, where we don't want to leave repos enabled because the
    image may be deployed many times and each instance needs to be
    re-registered. In t-h-t we don't have that problem because the
    script only runs at deploy time so it's okay and desirable to leave
    the repos enabled.

    Change-Id: I5d760467b458d90d74507a55effc49b71d22eaa3
    Closes-Bug: 1673116
    (cherry picked from commit 551baca688449f6f7f798577229cae39abbe6107)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/495452
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8acff7b29325867cae74b4236796d932f61fdd48
Submitter: Jenkins
Branch: stable/newton

commit 8acff7b29325867cae74b4236796d932f61fdd48
Author: Ben Nemec <email address hidden>
Date: Wed Mar 15 10:21:43 2017 -0500

    Don't disable satellite repo after registration

    Previously the rhel registration script disabled the satellite repo
    after installing packages from it. This means those packages will
    never be updated, which is not desirable from a long-term
    maintenance perspective.

    I believe this behavior is a holdover from the dib registration
    script, where we don't want to leave repos enabled because the
    image may be deployed many times and each instance needs to be
    re-registered. In t-h-t we don't have that problem because the
    script only runs at deploy time so it's okay and desirable to leave
    the repos enabled.

    Change-Id: I5d760467b458d90d74507a55effc49b71d22eaa3
    Closes-Bug: 1673116
    (cherry picked from commit 551baca688449f6f7f798577229cae39abbe6107)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.1 release.