"Cancel" button in "Delete Nodes" dialog is unlocalized

Bug #1672907 reported by Yuko Katabami
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
Expired
Undecided
Unassigned

Bug Description

"Cancel" button label is unlocalized.
Translation is available in Zanata.

Revision history for this message
Yuko Katabami (ykatabam) wrote :
Julie Pichon (jpichon)
tags: added: i18n ui
Changed in tripleo:
status: New → Triaged
importance: Undecided → Medium
milestone: none → pike-1
Revision history for this message
Yuko Katabami (ykatabam) wrote :

It is applicable to:
Delete Node dialog and Delete Deployment dialog.

Revision history for this message
Julie Pichon (jpichon) wrote :

Both these places use a "ConfirmationModel" to display the window, which contains an non-i18ned string for Cancel:

https://github.com/openstack/tripleo-ui/blob/4c8d6aa6/src/js/components/ui/ConfirmationModal.js#L47

Marking as a low-hanging-fruit - for an example of how to add i18n to a string see e.g. https://github.com/openstack/tripleo-ui/commit/b20142

tags: added: low-hanging-fruit ocata-backport-potential
Changed in tripleo:
milestone: pike-1 → pike-2
Changed in tripleo:
milestone: pike-2 → pike-3
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
milestone: pike-rc1 → queens-1
Changed in tripleo:
milestone: queens-1 → queens-2
Changed in tripleo:
milestone: queens-2 → queens-3
Changed in tripleo:
milestone: queens-3 → queens-rc1
Revision history for this message
Julie Pichon (jpichon) wrote :

Still an issue on master.

Changed in tripleo:
milestone: queens-rc1 → rocky-1
Changed in tripleo:
milestone: rocky-1 → rocky-2
Changed in tripleo:
milestone: rocky-2 → rocky-3
Changed in tripleo:
milestone: rocky-3 → rocky-rc1
Changed in tripleo:
milestone: rocky-rc1 → stein-1
Revision history for this message
Ganesh (gany) wrote :

I am interested in working on this bug. I have assigned it to myself.

Changed in tripleo:
assignee: nobody → Ganesh (gany)
Revision history for this message
Ganesh (gany) wrote :

Could anyone please confirm if this bug is still valid?

Revision history for this message
Yuko Katabami (ykatabam) wrote :

Thank you very much for your response.

I confirmed that the Cancel button is still unlocalized, however, "Delete Nodes" is localized.
"Delete Nodes" used to be a button on the top of the table, but was changed to hidden dropdown menu and those menu labels are localized.

I am attaching screenshots.

Revision history for this message
Yuko Katabami (ykatabam) wrote :
Revision history for this message
Ganesh (gany) wrote : Re: [Bug 1672907] Re: "Cancel" button in "Delete Nodes" dialog is unlocalized

Hi Yuko,

I am trying to bring up my development server but am facing issues. This is
primarily due to my environment being an Ubuntu VM. While most of the docs
assumes an RHEL.

I am currently facing an issue in Step 2 of this
<https://docs.openstack.org/tripleo-docs/latest/install/installation/installing.html>
guide.
I tried to convert the rpm to a deb using alien using an approach as
suggested here <https://askubuntu.com/a/2990> which did not work.

Any help around this would be greatly appreciated.

Regards
Ganesh

Changed in tripleo:
milestone: stein-1 → stein-2
Revision history for this message
Emilien Macchi (emilienm) wrote : Cleanup EOL bug report

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (FUTURE, PIKE, QUEENS, ROCKY, STEIN).
  Valid example: CONFIRMED FOR: FUTURE

Changed in tripleo:
assignee: Ganesh (gany) → nobody
importance: Medium → Undecided
status: Triaged → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.