onionbalance.service fails to add dependencies

Bug #1672901 reported by glitsj16
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
onionbalance (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Hi, looks like the systemd service file contains a comma where it should not. Even when not enabled, journalctl shows:

$ journalctl | grep onionbalance
Mar 15 00:10:51 lab16 systemd[1]: [/lib/systemd/system/onionbalance.service:8] Failed to add dependency on network.target,, ignoring: Invalid argument

The same typo exists in all Ubuntu onionbalance packages I checked (xenial, yakkety and zesty) and is easily fixed by removing the erroneous comma on line 8.

Regards.

= = =

$ cat /lib/systemd/system/onionbalance.service
# OnionBalance systemd target

[Unit]
Description=OnionBalance - Tor Onion Service load balancer
Documentation=man:onionbalance
Documentation=file:///usr/share/doc/onionbalance/html/index.html
Documentation=https://github.com/DonnchaC/onionbalance
After=network.target, tor.target <------------------------------------------------------ culprit
Wants=network-online.target
ConditionPathExists=/etc/onionbalance/config.yaml

[Service]
Type=simple
PIDFile=/run/onionbalance.pid
Environment="ONIONBALANCE_LOG_LOCATION=/var/log/onionbalance/log"
ExecStart=/usr/sbin/onionbalance -c /etc/onionbalance/config.yaml
ExecReload=/usr/sbin/onionbalance reload
ExecStop=-/sbin/start-stop-daemon --quiet --stop --retry=TERM/5/KILL/5 --pidfile /run/onionbalance.pid
TimeoutStopSec=5
KillMode=mixed

EnvironmentFile=-/etc/default/%p
User=onionbalance
PermissionsStartOnly=true
Restart=on-abnormal
RestartSec=2s
LimitNOFILE=65536

# Hardening
# AppArmorProfile=system_onionbalance
# CapabilityBoundingSet=CAP_NET_BIND_SERVICE CAP_CHOWN CAP_FOWNER
NoNewPrivileges=yes
PrivateDevices=yes
PrivateTmp=yes
ProtectHome=yes
ProtectSystem=full
ReadOnlyDirectories=/
ReadWriteDirectories=-/proc
# ReadWriteDirectories=-/var/lib/onionbalance
ReadWriteDirectories=-/var/log/onionbalance
ReadWriteDirectories=-/var/run

[Install]
WantedBy=multi-user.target

= = =

$ lsb_release -rd
Description: Ubuntu 16.04.2 LTS
Release: 16.04

= = =

$ apt-cache policy onionbalance
onionbalance:
  Installed: 0.1.3-3
  Candidate: 0.1.3-3
  Version table:
     0.1.3-3 500
        500 http://archive.ubuntu.com/ubuntu xenial/universe amd64 Packages

Changed in onionbalance (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.