test_arp_spoof_doesnt_block_normal_traffic fails with AttributeError: 'NoneType' object has no attribute 'splitlines'

[Ihar Hrachyshka]

http://logs.openstack.org/03/444603/5/check/gate-neutron-dsvm-functional-ubuntu-xenial/52405e2/testr_results.html.gz

Traceback (most recent call last):
  File "neutron/tests/base.py", line 116, in func
    return f(self, *args, **kwargs)
  File "neutron/tests/functional/agent/test_ovs_flows.py", line 182, in test_arp_spoof_doesnt_block_normal_traffic
    self._setup_arp_spoof_for_port(self.src_p.name, [self.src_addr])
  File "neutron/tests/functional/agent/test_ovs_flows.py", line 309, in _setup_arp_spoof_for_port
    self.br_int, vif, details)
  File "neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py", line 916, in setup_arp_spoofing_protection
    bridge.set_allowed_macs_for_port(vif.ofport, mac_addresses)
  File "neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/br_int.py", line 150, in set_allowed_macs_for_port
    in_port=port).splitlines()
AttributeError: 'NoneType' object has no attribute 'splitlines'

[Ihar Hrachyshka (ihar-hrachyshka)]

7 hits in 7 days.

[Ihar Hrachyshka (ihar-hrachyshka)]

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22AttributeError%3A%20'NoneType'%20object%20has%20no%20attribute%20'splitlines'%5C%22

[Ihar Hrachyshka (ihar-hrachyshka)]

The root cause is a segmentation fault in ovs itself:

2017-03-13T06:06:17.607Z|00002|daemon_unix(monitor)|ERR|1 crashes: pid 6301 died, killed (Segmentation fault), core dumped, restarting

but our code should be able to gracefully handle that.

[Ihar Hrachyshka (ihar-hrachyshka)]

The segfault is tracked in https://bugs.launchpad.net/neutron/+bug/1669900

[Ihar Hrachyshka (ihar-hrachyshka)]

The segfault is tracked in other place, removing gate-failure tag.

[Ihar Hrachyshka (ihar-hrachyshka)]

The bug is to make the code failing more gracefully on a similar ovs crash.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/482996

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/482996
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.