Wrong variable specified for rabbitmq haproxy configuration

[Nuriel Shem-Tov]

The 'ipaddresses' value of rabbitmq haproxy configuration is wrong and breaks deployment:
https://github.com/openstack/puppet-tripleo/blob/stable/newton/manifests/haproxy.pp#L945

Line 945 should be:

    ipaddresses => hiera('rabbitmq_node_ips', $controller_hosts_real),

Note that all other services configured in haproxy.pp are using "<service>_node_ips".

In depth:
If tripleo::haproxy::rabbitmq variable is set to 'true', the manifest will try to configure rabbitmq in haproxy.conf. However, deployment will break with:

Execution of '/usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg20170313-30724-1g1twnf -c' returned 1: [ALERT] 071/094401 (35003) : parsing [/etc/haproxy/haproxy.cfg20170313-30724-1g1twnf:218] : 'server overcloud-controller-0.internalapi.localdomain' : invalid address: 'internal_api' in 'internal_api:5672'

Because 'ipaddresses' is set to 'rabbitmq_network' it will get 'internal_api' configured which is a mistake. As mentioned above, 'rabbitmq_network' has to be changed to 'rabbitmq_node_ips'

[Michele Baldessari (michele)]

Note that this was never really worked on because rabbitmq does not use haproxy

[Nuriel Shem-Tov (nuri)]

Then it would make sense to remove it?
Though, we are making use of this in order to enable rabbitmq in haproxy to be used by Sensu.

We figured out that this was placed there in order to allow enabling it for exactly these kind of scenarios.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/552869

[Michele Baldessari (michele)]

No because we are still discussing if moving rabbitmq back under haproxy's loadbalancing on not (in the past it was removed because of linux kernel tcp bugs)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552869
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=35daa4f7f39dcd41e06dc75b9290ee6e07e9c255
Submitter: Zuul
Branch: master

commit 35daa4f7f39dcd41e06dc75b9290ee6e07e9c255
Author: Michele Baldessari <email address hidden>
Date: Wed Mar 14 11:26:33 2018 +0100

    Fix rabbitmq haproxy configuration

    While rabbitmq currently does not use haproxy at all, the code for
    it inside haproxy is currently wrong.
    Let's get this right in case we ever want to put rabbitmq back under
    haproxy's balancing

    Change-Id: Iaf1f818bdbde000ea3eedf0fb6503f60b3dddf75
    Closes-Bug: #1672356

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.0.0 release.