widelands

Selection is not cleared when new message arrives

Bug #1672059 reported by GunChleoc on 2017-03-11

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	widelands	Fix Released	Low	Unassigned	widelands build20-rc1

Bug Description

When a player receives a new message, the selection in the message box is not cleared. It would be annoying to have it cleared while the player is selecting stuff though - maybe not select the incoming message at all then?

Tags:

Related branches

lp:~widelands-dev/widelands/bug-1672059-table-message-arrival

Merged into lp:widelands at revision 8690

Notabilis: Approve on 2018-05-05

Revision history for this message

kaputtnik (franku) wrote on 2017-03-14:

The current selected message should not be cleared until another message is selected. I am fine with the current behavior and do not understand what the bug is...

Revision history for this message

GunChleoc (gunchleoc) wrote on 2017-03-15:

Scenario: User selected 1 message. Then, a new message arrives = user suddenly has 2 selected messages. And another new message = 3 selected messages etc...

Revision history for this message

GunChleoc (gunchleoc) wrote on 2017-03-15:

So, I guess the actual bug is: Do not select newly incoming messages unless the inbox was empty.

Revision history for this message

kaputtnik (franku) wrote on 2017-03-15:

When loading this savegame some new messages arrive after a short time Edit (270.8 KiB, application/octet-stream)

> Scenario: User selected 1 message. Then, a new message arrives = user suddenly has 2 selected messages. And another new message = 3 selected messages etc...

Thanks for explanantion, but i can't confirm this for a normal game. If i select a message and a new message arrives the previous selected message is the only selected one.

The same goes for the situation if the message get opened: The first message is selected and if a new message arrives the selected message is the only selected one.

For a scenario i didn't test this.

Don't know if it is worth a bug: If a savegame is loaded using another language, the images (e.g. of buildings) are not shown in the bottom section of the message menu. The attached savegame was saved using german language.

Revision history for this message

GunChleoc (gunchleoc) wrote on 2017-03-16:

I get that bug on trunk too, but not in

https://code.launchpad.net/~widelands-dev/widelands/fh1_width_and_mapobject_messages/+merge/318189

So, it will fix itself :)

Maybe the bug I reported here only happens in one of my branches - I don't remember which one now though.

Revision history for this message

GunChleoc (gunchleoc) wrote on 2017-05-26:

The bug happens only with popup messages, e.g. the status messages in Collectors.

The attached branch has the following fix:

- If the user selected more than one entry, we assume that the user is currently cleaning up stuff etc, so do not change the selection.

- In popup mode, if 1 message or no messages are selected, open the message window if it was closed and toogle to inbox. Clear the old selection and select the incoming message. Scroll to top.