FTBFS: undefined references - affects zesty/all arches (orthanc-webviewer 2.2-1)

Bug #1671955 reported by Tiago Stürmer Daitx
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
orthanc-webviewer (Debian)
Fix Released
Unknown
orthanc-webviewer (Ubuntu)
Fix Released
High
Unassigned

Bug Description

orthanc-webviewer 2.2-1 has been recently imported from Debian, unfortunately it FTBFS on all arches on zesty [1].

The failure is triggered when linking CXX shared library libOrthancWebViewer.so and causes quite a few "undefined reference" in GdcmImageDecoder.cpp.o

The root cause is the out-of-order argument for the gdcm library. This bug was introduced by the debian/patches/cmake (packaged since 1.1) where cmake's target_link_libraries for gdcm was replaced by a manual reference in LINK_FLAGS. The issue is that libraries should never be added to LINK_FLAGS (which behaves as LD_FLAGS in make) as they end up being declared before the objects that need them, instead the correct way is to rely on cmake's commands for that (there is no other equivalent to make's LD_LIBS).

[1] https://launchpad.net/ubuntu/+source/orthanc-webviewer/2.2-1

Tags: ftbfs patch
Revision history for this message
Tiago Stürmer Daitx (tdaitx) wrote :

The attached patch modifies debian/patches/cmake to prevent:
1. the manual inclusion of libraries in LINK_FLAGS
2. the removal of the call to target_link_libraries

Revision history for this message
Tiago Stürmer Daitx (tdaitx) wrote :

Correct debdiff with updated maintainer.

Changed in orthanc-webviewer (Ubuntu):
status: New → Confirmed
Changed in orthanc-webviewer (Debian):
status: Unknown → New
summary: - orthanc-webviewer 2.2-1 ftbfs on all arches
+ FTBFS: undefined references - affects zesty/all arches (orthanc-
+ webviewer 2.2-1)
tags: added: ftbfs patch
Mathew Hodson (mhodson)
Changed in orthanc-webviewer (Ubuntu):
importance: Undecided → High
Revision history for this message
Bhavani Shankar (bhavi) wrote :

Uploaded. Thanks!

Changed in orthanc-webviewer (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I'm unsubscribing ubuntu-sponsors.

If you need anything else sponsored, feel free to resubscribe.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package orthanc-webviewer - 2.2-1ubuntu1

---------------
orthanc-webviewer (2.2-1ubuntu1) zesty; urgency=medium

  * debian/patches/cmake: remove forced libraries and let cmake handle
    link dependencies. (Closes: #857355, LP: #1671955)

 -- Tiago Stürmer Daitx <email address hidden> Fri, 10 Mar 2017 22:27:14 +0000

Changed in orthanc-webviewer (Ubuntu):
status: Fix Committed → Fix Released
Changed in orthanc-webviewer (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.