scenario001 fails with due to panko-dbsync not being available

[Juan Antonio Osorio Robles]

Scenario001 has been failing the gate with the following trace:
2017-03-10 05:18:36.000 | Warning: This method is deprecated, please use match expressions with Stdlib::Compat::Bool instead. They are described at https://docs.puppet.com/puppet/latest/reference/lang_data_type.html#match-expressions. at :
2017-03-10 05:18:36.000 | (at /etc/puppet/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in `deprecation')
2017-03-10 05:18:36.000 | Warning: Scope(Oslo::Messaging::Rabbit[glance_api_config]): The oslo_messaging rabbit_host, rabbit_hosts, rabbit_port, rabbit_userid, rabbit_password, rabbit_virtual_host parameters have been deprecated by the [DEFAULT]\transport_url. Please use oslo::messaging::default::transport_url instead.
2017-03-10 05:18:36.000 | Warning: Scope(Oslo::Messaging::Rabbit[glance_registry_config]): The oslo_messaging rabbit_host, rabbit_hosts, rabbit_port, rabbit_userid, rabbit_password, rabbit_virtual_host parameters have been deprecated by the [DEFAULT]\transport_url. Please use oslo::messaging::default::transport_url instead.
2017-03-10 05:18:36.000 | Warning: Scope(Haproxy::Config[haproxy]): haproxy: The $merge_options parameter will default to true in the next major release. Please review the documentation regarding the implications.
2017-03-10 05:18:36.000 | Warning: This method is deprecated, please use match expressions with Stdlib::Compat::Float instead. They are described at https://docs.puppet.com/puppet/latest/reference/lang_data_type.html#match-expressions. at ["/etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd/collectd_plugin.pp", 5]:
2017-03-10 05:18:36.000 | (at /etc/puppet/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in `deprecation')
2017-03-10 05:18:36.000 | Error: /Stage[main]/Panko::Db::Sync/Exec[panko-db-sync]: Failed to call refresh: Could not find command 'panko-dbsync'
2017-03-10 05:18:36.000 | Error: /Stage[main]/Panko::Db::Sync/Exec[panko-db-sync]: Could not find command 'panko-dbsync'

Now, for some reason panko-dbsync is not available.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/444120

[Steven Hardy (shardy)]

[stack@undercloud actions]$ sudo yum whatprovides panko-dbsync
Loaded plugins: fastestmirror, priorities
Loading mirror speeds from cached hostfile
704 packages excluded due to repository priority protections
base/7/x86_64/filelists_db | 6.6 MB 00:00:01
centos-ceph-jewel/7/x86_64/filelists_db | 19 kB 00:00:00
delorean/filelists_db | 741 kB 00:00:00
delorean-current/filelists_db | 738 kB 00:00:00
delorean-ocata-testing/x86_64/filelists_db | 2.4 MB 00:00:00
extras/7/x86_64/filelists_db | 596 kB 00:00:00
rdo-qemu-ev/x86_64/filelists_db | 18 kB 00:00:00
updates/7/x86_64/filelists_db | 2.2 MB 00:00:00
openstack-panko-api-2.0.1-0.20170222143558.8a8f49a.el7.centos.noarch : OpenStack panko api
Repo : delorean
Matched from:
Filename : /usr/bin/panko-dbsync

openstack-panko-api-2.0.1-0.20170222143558.8a8f49a.el7.centos.noarch : OpenStack panko api
Repo : @delorean
Matched from:
Filename : /bin/panko-dbsync

openstack-panko-api-2.0.1-0.20170222143558.8a8f49a.el7.centos.noarch : OpenStack panko api
Repo : @delorean
Matched from:
Filename : /usr/bin/panko-dbsync

So I'm not sure how adding panko-common helps here, and also that should be included already due to dependencies: http://paste.openstack.org/show/602196/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/444120
Reason: panko-common is in the overcloud. this is not needed.

[Juan Antonio Osorio Robles (juan-osorio-robles)]

Steve, I already abandoned the commit (as mentioned on IRC). but it does seem that panko-api is missing http://logs.openstack.org/48/443148/1/check/gate-tripleo-ci-centos-7-scenario001-multinode/4a25722/logs/subnode-2/rpm-qa.txt.gz

[Steven Hardy (shardy)]

Ok so digging into this, it seems we're not using elements any more for any multinode jobs:

https://github.com/openstack-infra/tripleo-ci/commit/4a4c8a1c761567f4a4bc85f25a640bd209639fc3

https://review.openstack.org/#/c/411445/10/environments/deployed-server-bootstrap-environment-centos.yaml

I feel like that's something of a step backwards in terms of multinode coverage, but it does mean the issue here is probably a bug in puppet-panko vs a problem with TripleO itself?

[Juan Antonio Osorio Robles (juan-osorio-robles)]

It was actually an issue with how we include the db sync in puppet-tripleo, I'm fixing it here: https://review.openstack.org/#/c/444182/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444182
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=d73c2630b534b277122db68620be8923c4d3a6b4
Submitter: Jenkins
Branch: master

commit d73c2630b534b277122db68620be8923c4d3a6b4
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Fri Mar 10 11:44:56 2017 +0200

    panko: Do db_sync in api manifest

    The db_sync from panko comes from the panko-api package; So we move the
    db_sync to be done in the api manifest as it's done for other services
    such as barbican.

    This is necessary since in cases where the overcloud deploy requires
    puppet to do the installations, with the previous setup it failed since
    the command wasn't available in the step it was being done.

    Change-Id: I20a549cbaa2ee4b2c762dbae97f5cbf4d0b517c8
    Closes-Bug: #1671716

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/444338

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444338
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=d71efd8a8f2284be9c24ec5b6e5a12f067e5d706
Submitter: Jenkins
Branch: stable/ocata

commit d71efd8a8f2284be9c24ec5b6e5a12f067e5d706
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Fri Mar 10 11:44:56 2017 +0200

    panko: Do db_sync in api manifest

    The db_sync from panko comes from the panko-api package; So we move the
    db_sync to be done in the api manifest as it's done for other services
    such as barbican.

    This is necessary since in cases where the overcloud deploy requires
    puppet to do the installations, with the previous setup it failed since
    the command wasn't available in the step it was being done.

    Change-Id: I20a549cbaa2ee4b2c762dbae97f5cbf4d0b517c8
    Closes-Bug: #1671716
    (cherry picked from commit d73c2630b534b277122db68620be8923c4d3a6b4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 6.4.0 release.