OpenStack Dashboard (Horizon)

shared field in network-edit from should be controlled by 'update_network:shared' policy

Bug #1671595 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki
OpenStack Dashboard (Horizon) pike-1

Bug Description

'shared' field in the network edit form refers to the policy 'create_network:shared'. It should be 'update_network:shared'.

https://github.com/openstack/horizon/blob/3e195b61e0aa3ea979ff63758dd0da5834e30218/openstack_dashboard/dashboards/project/networks/forms.py#L52

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/443927

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/443927
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=13a4cef86924c51e98afd1c460aef163c429bfa5
Submitter: Jenkins
Branch: master

commit 13a4cef86924c51e98afd1c460aef163c429bfa5
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 9 18:17:03 2017 +0000

    Use correct policy name for "Edit Network" form setup

    UpdateNetwork form should use 'update_network:shared' instead of
    'create_update:shared' to check 'shared' field can be edited.

    Change-Id: I482e98a36a7fb5abc7131d413d2ebde36503d8ab
    Closes-Bug: #1671595

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/445413

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/ocata)

Reviewed: https://review.openstack.org/445413
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7603ae629a55f6f7924f6f3e375ed1ea400a71fc
Submitter: Jenkins
Branch: stable/ocata

commit 7603ae629a55f6f7924f6f3e375ed1ea400a71fc
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 9 18:17:03 2017 +0000

    Use correct policy name for "Edit Network" form setup

    UpdateNetwork form should use 'update_network:shared' instead of
    'create_update:shared' to check 'shared' field can be edited.

    Change-Id: I482e98a36a7fb5abc7131d413d2ebde36503d8ab
    Closes-Bug: #1671595
    (cherry picked from commit 13a4cef86924c51e98afd1c460aef163c429bfa5)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.2

This issue was fixed in the openstack/horizon 11.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.