godeps plugin does not installing the git package by itself

[Xavi Garcia]

This happened when building on launchpad.
The godeps plugin should install git.

I tried to add git in the build-packages section and it works as a workaround.

This is a build example:
https://code.launchpad.net/~xavi-garcia-mena/+snap/godeps-test

This is the end of the build log:
go: missing Git command. See https://golang.org/s/gogetcmd
package github.com/rogpeppe/godeps: exec: "git": executable file not found in $PATH
Command '['/bin/sh', '/tmp/tmp2w8ecs_k', 'go', 'get', 'github.com/rogpeppe/godeps']' returned non-zero exit status 1
go get github.com/rogpeppe/godeps
Traceback (most recent call last):
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 202, in main
    builder.pull()
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 139, in pull
    env=env)
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 92, in run_build_command
    self.chroot(["/bin/sh", "-c", command], echo=echo)
  File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 66, in chroot
    "/usr/bin/sudo", "/usr/sbin/chroot", self.chroot_path] + args)
  File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '['/usr/bin/sudo', '/usr/sbin/chroot', '/home/buildd/build-SNAPBUILD-26732/chroot-autobuild', 'linux32', '/bin/sh', '-c', 'cd /build/godeps-test && env LANG=C.UTF-8 https_proxy=http://snap-proxy.launchpad.net:3128 SNAPCRAFT_SETUP_CORE=1 http_proxy=http://snap-proxy.launchpad.net:3128 SNAPCRAFT_LOCAL_SOURCES=1 snapcraft pull']' returned non-zero exit status 1
Revoking proxy token...
RUN: /usr/share/launchpad-buildd/slavebin/scan-for-processes ['scan-for-processes', 'SNAPBUILD-26732']
Scanning for processes to kill in build /home/buildd/build-SNAPBUILD-26732/chroot-autobuild...
RUN: /usr/share/launchpad-buildd/slavebin/umount-chroot ['umount-chroot', 'SNAPBUILD-26732']
Unmounting chroot for build SNAPBUILD-26732...
RUN: /usr/share/launchpad-buildd/slavebin/remove-build ['remove-build', 'SNAPBUILD-26732']

[Colin Watson (cjwatson)]

https://github.com/snapcore/snapcraft/pull/1179