Tests in neutron.tests.tempest.api.test_revisions.TestRevisions don't clean up network resources

[Eran Kuris]

Tests in neutron.tests.tempest.api.test_revisions.TestRevisions create networks but don't remove them when each test is finished.
Cleanup only occurs after all the tests finish to run.

[Anindita Das (anindita-das)]

Hi Erin,

Because of this are you having any issues? Can you please elaborate?

Thanks,
Anindita

[Eran Kuris (ekuris)]

When you run on this tests : neutron.tests.tempest.api.test_revisions.TestRevisions* (21 tests)
with default network quotas (10) 5 tests will be failed , because cleanup of this test done only in the end .

More clear ?

[Anindita Das (anindita-das)]

Eran:

I found 4 tests are failing. Here is the trace http://paste.openstack.org/show/602444/. Are you seeing the same tests fail?

[Eran Kuris (ekuris)]

Yes same I see the same .

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/448973

[Ihar Hrachyshka (ihar-hrachyshka)]

For master, it was somewhat solved by https://review.openstack.org/#/c/444030/ but 1) we need something backportable; 2) it would still affect us if there were a lot of test cases that create enough networks to hit the new limit.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/448973
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0e1fa9c7ee1f41045216ce96bbd8305c9fc0bb97
Submitter: Jenkins
Branch: master

commit 0e1fa9c7ee1f41045216ce96bbd8305c9fc0bb97
Author: Prateek Arora <email address hidden>
Date: Mon Mar 27 11:30:47 2017 -0400

    Fix Quota error while running tests

    The test methods in the test class create networks and the cleanup
    takes place after all tests are run. As such installation specific
    default quota (that was e.g. just 10 networks till Pike) may be hit and
    tests then fail.

    This patch reduces the chance that the quota limit is not hit by
    speeding up network resource cleanup (doing it after each test case
    completed, not when the whole test class is cleaned up).

    Change-Id: I6ba2704c60c77d89e00842e28bece14c64ef98a6
    Closes-bug: #1671478

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/450574

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/450577

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/450577
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a322266ddc5b01295610dfd469161a1fa186dce2
Submitter: Jenkins
Branch: stable/newton

commit a322266ddc5b01295610dfd469161a1fa186dce2
Author: Prateek Arora <email address hidden>
Date: Mon Mar 27 11:30:47 2017 -0400

    Fix Quota error while running tests

    The test methods in the test class create networks and the cleanup
    takes place after all tests are run. As such installation specific
    default quota (that was e.g. just 10 networks till Pike) may be hit and
    tests then fail.

    This patch reduces the chance that the quota limit is not hit by
    speeding up network resource cleanup (doing it after each test case
    completed, not when the whole test class is cleaned up).

    Change-Id: I6ba2704c60c77d89e00842e28bece14c64ef98a6
    Closes-bug: #1671478
    (cherry picked from commit d0af6d736f9078aa124607ee52e10ff96c09eea8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/450574
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dfe4f2169c80a3f327cc504bbf86ea56f818e633
Submitter: Jenkins
Branch: stable/ocata

commit dfe4f2169c80a3f327cc504bbf86ea56f818e633
Author: Prateek Arora <email address hidden>
Date: Mon Mar 27 11:30:47 2017 -0400

    Fix Quota error while running tests

    The test methods in the test class create networks and the cleanup
    takes place after all tests are run. As such installation specific
    default quota (that was e.g. just 10 networks till Pike) may be hit and
    tests then fail.

    This patch reduces the chance that the quota limit is not hit by
    speeding up network resource cleanup (doing it after each test case
    completed, not when the whole test class is cleaned up).

    Change-Id: I6ba2704c60c77d89e00842e28bece14c64ef98a6
    Closes-bug: #1671478
    (cherry picked from commit 0e1fa9c7ee1f41045216ce96bbd8305c9fc0bb97)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.