xfstest fails when inserting blocks at same offset ( ext4 )

[bugproxy]

--------------------------
xfstest fails with wrong md5 sum when inserting blocks at same offset

# uname -a
Linux ltc-haba1 4.10.0-8-generic #10-Ubuntu SMP Mon Feb 13 14:00:06 UTC 2017 ppc64le ppc64le ppc64le GNU/Linux

Steps to reproduce:
----------------------------------------
1. Create a loop device with ext4 filesystem
2. git clone git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git; cd xfstests-dev
3. ./configure && make
4. Create a local.conf for running with created loop device
5.. Run xfstests-dev test : ./check -g auto

The test 404 fails with following
-#342 2fef7cc7c9b24f9a37b63c85b24a999a -
-#343 1608cc4f11dfd20a29586353970d8490 -
-#344 cf8c90020b16d7fdda010494d45c8471 -
-#345 47aa3937b31eeb6a56bcc2f6f46d6311 -
...
+#342 dd2a1e366aebeea3c6f0f466095a7426 -
+#343 caa72c4045b0fe41305ff7eaaa5bfe69 -
+#344 e65f3a3ec70d2bdf7d58f5d5fc6d3808 -
+#345 a15105b7b99f8763678f58e8279323ac -

md5sum is different for last 158 blocks

Full fail log is attached.

Particular test case 404 was added newly as a part of commit 2504b26a3a71d499ff745cdb007556ba20123fe5.

[bugproxy (bugproxy)]

Default Comment by Bridge

[bugproxy (bugproxy)]

------- Comment on attachment From <email address hidden> 2017-03-23 03:01 EDT-------

Backported patch (above) and Kernel debian package build at 17.04 is provided.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-03-21 00:46 EDT-------
The commit which adds generic/404 test indicates two kernel commits which fixes this issue,

commit 2a9b8cba62c0741109c33a2be700ff3d7703a7c2
Author: Roman Pen <email address hidden>
Date: Sun Jan 8 20:59:35 2017 -0500

ext4: Include forgotten start block on fallocate insert range

And,

commit 03e916fa8b5577d85471452a3d0c5738aa658dae
Author: Roman Pen <email address hidden>
Date: Sun Jan 8 21:00:35 2017 -0500

ext4: do not polute the extents cache while shifting extents

Seeteena, Can you please try and backport these commits from the upstream kernel and provide a kernel deb package for further testing?

------- Comment From <email address hidden> 2017-03-27 08:10 EDT-------
Please cherry pick.

commit 2a9b8cba62c0741109c33a2be700ff3d7703a7c2
Author: Roman Pen <email address hidden>
Date: Sun Jan 8 20:59:35 2017 -0500

ext4: Include forgotten start block on fallocate insert range

And,

commit 03e916fa8b5577d85471452a3d0c5738aa658dae
Author: Roman Pen <email address hidden>
Date: Sun Jan 8 21:00:35 2017 -0500

ext4: do not polute the extents cache while shifting extents

Attached patch

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-08-23 09:14 EDT-------
Distro team, Any update on cherry pick of the above patches ?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2018-03-12 09:13 EDT-------
(In reply to comment #19)
> Distro team, Any update on cherry pick of the above patches ?

This needs to be tested on Ubuntu 17.04 or 18.04? If so, which kernel includes the patch mentioned?

Thanks,
Harish

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2018-05-21 04:55 EDT-------
(In reply to comment #20)
> (In reply to comment #19)
> > Distro team, Any update on cherry pick of the above patches ?
>
> This needs to be tested on Ubuntu 17.04 or 18.04? If so, which kernel
> includes the patch mentioned?
>
> Thanks,
> Harish

Distro team, please comment..

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2018-07-02 00:12 EDT-------
Hi

Verified this bug on ubuntu18.04.1 and issue seems me fixed .

LOG:

root@ltc-wspoon12:~/xfstests# ./check generic/404
FSTYP -- ext4
PLATFORM -- Linux/ppc64le ltc-wspoon12 4.15.0-24-generic
MKFS_OPTIONS -- /dev/loop1
MOUNT_OPTIONS -- -o acl,user_xattr /dev/loop1 /mnt/scratch

generic/404 8s ... 8s
Ran: generic/404
Passed all 1 tests

root@ltc-wspoon12:~/xfstests#

Regards
Praveen