Usage of CinderNfsShares no longer works

[Elise Gafford]

When the NFS Cinder backend is used, CinderNfsShares must be defined as a list to avoid a crashing failure when the Cinder puppet module attempts a join on this list. This default is currently an empty string, but should be an empty list. Though in a real deployment, this default will not likely be used (since defining servers is rather critical,) providing the correct default type will help users to avoid this error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/448208

[Christian Schwede (cschwede)]

Actually there is a regression somewhere.

In the past it was working with parameter_defaults like this:

 CinderNfsServers: '10.0.0.254:/srv/nfs/cinder'
or
 CinderNfsServers: "[fd00:fd00:fd00:3000::1]:/srv/nfs/cinder"

The problem is that the templating escapes these strings, and puppet-tripleo didn't receive a proper array, but a string.

I proposed a fix: https://review.openstack.org/#/c/448208/1

In my tests this worked both with the two examples above, as well with comma-separated lists of entries.

[Christian Schwede (cschwede)]

For reference, this is the kind of error you'll see when using the following extra parameters:

parameter_defaults:
  CinderEnableNfsBackend: true
  CinderNfsServers: '127.0.0.1:/tmp'

This no longer happens when using the proposed upstream patch (https://review.openstack.org/#/c/448208/).

2017-03-22 08:28:00Z [overcloud-AllNodesDeploySteps-73agpy3ks6ka-ControllerDeployment_Step4-jk5jrepjuakr.0]: SIGNAL_IN_PROGRESS Signal: deployment 8cdc0017-5a38-44db-9274-09ea8a2a6669 failed (1)
2017-03-22 08:28:01Z [overcloud-AllNodesDeploySteps-73agpy3ks6ka-ControllerDeployment_Step4-jk5jrepjuakr.0]: UPDATE_FAILED Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 1
2017-03-22 08:28:01Z [overcloud-AllNodesDeploySteps-73agpy3ks6ka-ControllerDeployment_Step4-jk5jrepjuakr]: UPDATE_FAILED Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 1
2017-03-22 08:28:02Z [overcloud-AllNodesDeploySteps-73agpy3ks6ka.ControllerDeployment_Step4]: UPDATE_FAILED resources.ControllerDeployment_Step4: Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 1
2017-03-22 08:28:02Z [overcloud-AllNodesDeploySteps-73agpy3ks6ka]: UPDATE_FAILED resources.ControllerDeployment_Step4: Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 1
2017-03-22 08:28:03Z [AllNodesDeploySteps]: UPDATE_FAILED resources.AllNodesDeploySteps: resources.ControllerDeployment_Step4: Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 1
2017-03-22 08:28:03Z [overcloud]: UPDATE_FAILED resources.AllNodesDeploySteps: resources.ControllerDeployment_Step4: Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 1

 Stack overcloud UPDATE_FAILED

overcloud.AllNodesDeploySteps.ControllerDeployment_Step4.0:
  resource_type: OS::Heat::StructuredDeployment
  physical_resource_id: 8cdc0017-5a38-44db-9274-09ea8a2a6669
  status: UPDATE_FAILED
  status_reason: |
    Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 1
  deploy_stdout: |
    Notice: hiera(): Cannot load backend module_data: cannot load such file -- hiera/backend/module_data_backend
    Notice: Scope(Class[Tripleo::Firewall::Post]): At this stage, all network traffic is blocked.
  deploy_stderr: |
    ...
    Warning: ModuleLoader: module 'horizon' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules
       (file & line not available)
    Warning: Undefined variable '';
       (file & line not available)
    Warning: You cannot collect exported resources without storeconfigs being set; the collection will be ignored at /etc/puppet/modules/gnocchi/manifests/api.pp:129:5
    Warning: Scope(Class[Aodh]): aodh::rabbit_host, aodh::rabbit_hosts, aodh::rabbit_password, aodh::rabbit_port, aodh::rabbit_userid and aodh::rabbit_virtual_host ...

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/448208

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/448208
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9445b0e0972696e7de1c0a702f456571d12fa964
Submitter: Jenkins
Branch: master

commit 9445b0e0972696e7de1c0a702f456571d12fa964
Author: Christian Schwede <email address hidden>
Date: Tue Mar 21 18:28:34 2017 +0100

    Fix usage of CinderNfsServers

    This feature stopped working somewhere along the lines. In the past it
    was working with parameter_defaults like this:

     CinderNfsServers: '10.0.0.254:/srv/nfs/cinder'

    or

     CinderNfsServers: "[fd00:fd00:fd00:3000::1]:/srv/nfs/cinder"

    The problem was that the templating escaped these strings, and
    puppet-tripleo didn't receive a proper array, but a string.

    This patch fixes this. It accepts strings as above as well as
    comma-delimited lists of Nfs Servers.

    Closes-Bug: 1671153
    Change-Id: I89439c1d969e92cb8e0503de561e22409deafdfc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/450085

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/450085
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8b7a995df3014d1da312424278dc4753a34f44a6
Submitter: Jenkins
Branch: stable/ocata

commit 8b7a995df3014d1da312424278dc4753a34f44a6
Author: Christian Schwede <email address hidden>
Date: Tue Mar 21 18:28:34 2017 +0100

    Fix usage of CinderNfsServers

    This feature stopped working somewhere along the lines. In the past it
    was working with parameter_defaults like this:

     CinderNfsServers: '10.0.0.254:/srv/nfs/cinder'

    or

     CinderNfsServers: "[fd00:fd00:fd00:3000::1]:/srv/nfs/cinder"

    The problem was that the templating escaped these strings, and
    puppet-tripleo didn't receive a proper array, but a string.

    This patch fixes this. It accepts strings as above as well as
    comma-delimited lists of Nfs Servers.

    Closes-Bug: 1671153
    Change-Id: I89439c1d969e92cb8e0503de561e22409deafdfc
    (cherry picked from commit 9445b0e0972696e7de1c0a702f456571d12fa964)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.1.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/442038
Reason: Per policy documented here: http://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandomment.html - we decided to abandon this patch. If you want to work on it again, feel free to restore it. Any question about that can be asked on #tripleo.