Live migration of paused instance fails when post copy is enabled

[Sivasathurappan Radhakrishnan]

live migration paused instance fails when post copy is enabled.

Steps to Reproduce:

* spin up a instance and pause it
  nova pause <instance>

* Live migrate the instance
  nova live-migration <instance> <host>

Expected result
===============
live migration should go through without any errors
Actual result
=============
Live migration command returns 202 but I could see libvirt failure while doing live-migration in compute logs.

Environment:

Multinode devstack environment with 2 compute nodes.
1)Current master
2)Networking-neutron
3)Hypervisor Libvirt-KVM
3) Enable post copy for which libvirt version should be greater than or equal to 1.3.3.

Logs:
Following error found in compute log
http://paste.openstack.org/show/601362/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/444517

[OpenStack Infra (hudson-openstack)]

Change abandoned by Stephen Finucane (<email address hidden>) on branch: master
Review: https://review.openstack.org/444517
Reason: This has been here for some time with no updates. Abandoning to clean up the review queue

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/444517
Committed: https://opendev.org/openstack/nova/commit/33fa92b6cb1dfeb88a4188c0e4e4ce51be1f7a4b
Submitter: "Zuul (22348)"
Branch: master

commit 33fa92b6cb1dfeb88a4188c0e4e4ce51be1f7a4b
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Fri Mar 10 22:16:42 2017 +0000

    Allow live migrate paused instance when post copy is enabled

    Live migration of paused instance fails when VIR_MIGRATE_POSTCOPY
    flag is set. In this patch, the flag is unset to permit live migration
    of paused instance.

    Change-Id: Ib5cbc948cb953e35a22bcbb859976f0afddcb662
    Closes-Bug: #1671011

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/nova/+/903834

[Olaf Seibert (oseibert-sys11)]

In the patch given in bug https://bugs.launchpad.net/nova/+bug/1946752 the POSTCOPY flag is disabled in two locations. The fix here only does it in one of the two. It misses the later variable named `is_post_copy_enabled`.

Are we sure that that is sufficient?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/903834
Committed: https://opendev.org/openstack/nova/commit/989ee448906f4ca623f6b14ef8c7af8c8fa10e2f
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 989ee448906f4ca623f6b14ef8c7af8c8fa10e2f
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Fri Mar 10 22:16:42 2017 +0000

    Allow live migrate paused instance when post copy is enabled

    Live migration of paused instance fails when VIR_MIGRATE_POSTCOPY
    flag is set. In this patch, the flag is unset to permit live migration
    of paused instance.

    Change-Id: Ib5cbc948cb953e35a22bcbb859976f0afddcb662
    Closes-Bug: #1671011
    (cherry picked from commit 33fa92b6cb1dfeb88a4188c0e4e4ce51be1f7a4b)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/nova/+/903840

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/903840
Committed: https://opendev.org/openstack/nova/commit/5db7a7b3db2c394b4cda095dfe3a0a72f8106466
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 5db7a7b3db2c394b4cda095dfe3a0a72f8106466
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Fri Mar 10 22:16:42 2017 +0000

    Allow live migrate paused instance when post copy is enabled

    Live migration of paused instance fails when VIR_MIGRATE_POSTCOPY
    flag is set. In this patch, the flag is unset to permit live migration
    of paused instance.

    Change-Id: Ib5cbc948cb953e35a22bcbb859976f0afddcb662
    Closes-Bug: #1671011
    (cherry picked from commit 33fa92b6cb1dfeb88a4188c0e4e4ce51be1f7a4b)
    (cherry picked from commit 989ee448906f4ca623f6b14ef8c7af8c8fa10e2f)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/nova/+/904085

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/904085
Committed: https://opendev.org/openstack/nova/commit/787839f6637f292fb5656725e5dae12fbe6e3c3e
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 787839f6637f292fb5656725e5dae12fbe6e3c3e
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Fri Mar 10 22:16:42 2017 +0000

    Allow live migrate paused instance when post copy is enabled

    Live migration of paused instance fails when VIR_MIGRATE_POSTCOPY
    flag is set. In this patch, the flag is unset to permit live migration
    of paused instance.

    Change-Id: Ib5cbc948cb953e35a22bcbb859976f0afddcb662
    Closes-Bug: #1671011
    (cherry picked from commit 33fa92b6cb1dfeb88a4188c0e4e4ce51be1f7a4b)
    (cherry picked from commit 989ee448906f4ca623f6b14ef8c7af8c8fa10e2f)
    (cherry picked from commit 5db7a7b3db2c394b4cda095dfe3a0a72f8106466)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 26.2.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 29.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 27.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 28.1.0 release.