Script loading broken since import commit

Bug #1670825 reported by Vadim Peretokin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mudlet
Fix Released
Critical
Stephen Lyons

Bug Description

a7f81aafd9897cf38137f22638bfc3bca4d9f0d5 and the corresponding commit in release_30 are causing scripts not to load right:

https://cdn.discordapp.com/attachments/283582439002210305/288765736669806595/unknown.png
https://cdn.discordapp.com/attachments/283582439002210305/288765804420530176/unknown.png
https://cdn.discordapp.com/attachments/283582439002210305/288766212517920768/unknown.png

This issue was confirmed in latest development and release_30 branches. It was also independently confirmed by another user: https://gitter.im/Mudlet/Mudlet?at=58b88f0b21d548df2c8165c7

The issue is that the children scripts are being run before the parent script, which is not the desired behaviour - scripts are supposed to run in the visual order they are in.

Revision history for this message
Vadim Peretokin (vperetokin) wrote :

@slysven mind having a look at this?

description: updated
Changed in mudlet:
status: New → Confirmed
assignee: nobody → Stephen Lyons (slysven)
Revision history for this message
Stephen Lyons (slysven) wrote :

Oh, b****r! I'd seen something like that in the past with the Spork GUI for (SlothMUD ?) where the scripts were not being loaded in the order that the package was designed for (or the variables were NOT marked to be saved between sessions).

Will probe the behaviour and check the loading/compiling/execution order...

Revision history for this message
Stephen Lyons (slysven) wrote :

Fixes are now available in https://github.com/Mudlet/Mudlet/pull/417 (development) and https://github.com/Mudlet/Mudlet/pull/416 (release_30). I discovered a further, possibly significant issue, but was unable to fix it within a reasonable time-frame so have abandoned an all-in-one attempt in https://github.com/Mudlet/Mudlet/pull/413 working in the development branch.

Changed in mudlet:
status: Confirmed → In Progress
Revision history for this message
Vadim Peretokin (vperetokin) wrote :

Thanks for turning this around quickly! I'll mark it as "fix released" since it never made it into a release and the issue is fixed for everyone now...

Changed in mudlet:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.