Menu entries missing from Horizon if cinder v1 endpoint is deleted

[Radoslav]

In the case where there is no cinder v1 endpoint created (or deleted - use openstack service delete cinder to reproduce) certain volume related menu entries are not displayed - Create volume from instance snapshot and create instance from volume - see attachments.

[Lucas H. Xu (xuh-2)]

I can confirm this in devstack horizon.

[Radomir Dopieralski (deshipu)]

The error is possibly in this check, which should check for both 'volume' and 'volumev2':

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js#L547-L549

[Lucas H. Xu (xuh-2)]

And here: https://github.com/openstack/horizon/blob/4187837434d4501fddb2f72b91f27ab0a8288305/openstack_dashboard/static/app/core/images/actions/create-volume.service.js#L75

Should do a check. I could take this task unless Radomir wants to do it :)

[Radomir Dopieralski (deshipu)]

I'm helpless with Angular, so please take it.

[Radoslav (radoslav-milanov)]

Can you make the check to consider Cinder present if any version is present - v1,v2,v3?

[Lucas H. Xu (xuh-2)]

Not sure if it is necessary to check v3 right now. Haven't seen any implementation in the code base for checking that yet. Will give a careful look on this. Thanks! Expecting to send out a patch for review by the end of this week.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/449317

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/449317
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5ced2f87ef3b480f9d795a3c1ba648a1d0a072df
Submitter: Jenkins
Branch: master

commit 5ced2f87ef3b480f9d795a3c1ba648a1d0a072df
Author: Lucas H. Xu <email address hidden>
Date: Thu Mar 23 16:39:58 2017 -0400

    Change checking cinder v1 to check v2 in panels

    In general, in the case where there is no cinder v1 endpoint created
    (or deleted - use openstack service delete cinder to reproduce) certain
    volume related menu entries are not displayed

    This patch add a a new function to check cinder v2/v3 endpoints instead
    of only checking the v1 endpoint in instance launch model.

    Also, in the image panel, instead of checking v1 endpoint,
    it should check v2 and v3 as well.

    Change-Id: I642b2f62bb9502f958593c9fcad76e21ee1c80ad
    Closes-Bug: #1670789

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/450566

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/450566
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7c2cd41ca2f8843fcc5931b308f1bf13a8b31606
Submitter: Jenkins
Branch: stable/ocata

commit 7c2cd41ca2f8843fcc5931b308f1bf13a8b31606
Author: Lucas H. Xu <email address hidden>
Date: Thu Mar 23 16:39:58 2017 -0400

    Change checking cinder v1 to check v2 in panels

    In general, in the case where there is no cinder v1 endpoint created
    (or deleted - use openstack service delete cinder to reproduce) certain
    volume related menu entries are not displayed

    This patch add a a new function to check cinder v2/v3 endpoints instead
    of only checking the v1 endpoint in instance launch model.

    Also, in the image panel, instead of checking v1 endpoint,
    it should check v2 and v3 as well.

    Change-Id: I642b2f62bb9502f958593c9fcad76e21ee1c80ad
    Closes-Bug: #1670789
    (cherry picked from commit 5ced2f87ef3b480f9d795a3c1ba648a1d0a072df)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 11.0.3 release.