[10.0 swarm] Invalid definition of disk size

[Sergey Novikov]

Detailed bug description:

The issue was found by https://product-ci.infra.mirantis.net/job/10.0.system_test.ubuntu.thread_usb/201/console

Test fails with

  File "/home/jenkins/workspace/10.0.system_test.ubuntu.thread_usb/fuelweb_test/tests/test_ha_one_controller_base.py", line 47, in deploy_ha_one_controller_neutron_base
    check_free_space_admin(self.env)
  File "/home/jenkins/workspace/10.0.system_test.ubuntu.thread_usb/fuelweb_test/helpers/checkers.py", line 1380, in check_free_space_admin
    min_disk_admin, disk_size_admin))
ValueError: The minimal disk size should be 53687091200, current 2396798976

Although default value of disk size is 75GB for master node [0] and this value is not overrided for the test. So, the root cause of failure is invalid definition of disk size [1]. There isn't taking into account that created disk is extended dynamic volume - we need to take "virtual size" instead "disk size" [2]

[0] - https://github.com/openstack/fuel-devops/blob/3.0.3/devops/settings.py#L94
[1] - https://github.com/openstack/fuel-devops/blob/0504ccdfa9bb5412f878f7af1ff5b38aecb9c393/devops/driver/libvirt/libvirt_driver.py#L908
[2] - http://paste.openstack.org/show/601776/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/444115

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444115
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=3d22d0c2662c6586f16a32e37a6f20e4a6889692
Submitter: Jenkins
Branch: stable/newton

commit 3d22d0c2662c6586f16a32e37a6f20e4a6889692
Author: Dmitry Belyaninov <email address hidden>
Date: Fri Mar 10 07:36:33 2017 +0100

    Change disk size check

    Sometimes order of disks can be changed. So we need
    to select disk using type ("qcow2" by default) but
    not by index.

    Change-Id: I481eb79eff22b990c61d2397d6c96bd93df6687f
    Closes-Bug: 1670711

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/445779

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/445781

[OpenStack Infra (hudson-openstack)]

Change abandoned by Vladimir Khlyunev (<email address hidden>) on branch: master
Review: https://review.openstack.org/445781
Reason: more than 1 year old

[OpenStack Infra (hudson-openstack)]

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/ocata
Review: https://review.opendev.org/445779
Reason: This repo is retired now, no further work will get merged.