Typo in error msg when no crashkernel memory reservation is set

[Eric Desrochers]

[Impact]

 * There is a typo in ERRMSG of function show_mem_usage affecting Xenial/Zesty, Debian and makedumpfile upstream.

This should be :
"show_mem_usage: No memory is reserved for crashkernel!"

instead of :
"show_mem_usage: No memory is reserved for crashkenrel!"

The typo is located here in src code :

# filename : makedumpfile.c
-
        int show_mem_usage(void)
         {
         uint64_t vmcoreinfo_addr, vmcoreinfo_len;
         struct cycle cycle = {0};

         if (!is_crashkernel_mem_reserved()) {
               ==>  ERRMSG("No memory is reserved for crashkenrel!\n");
                 return FALSE;
         }
-

[Test Case]

 * Take a system with no crashkernel memory reservation set
 * run command : makedumpfile --mem-usage /proc/kcore

 * Error message :
show_mem_usage: No memory is reserved for crashkenrel!

[Regression Potential]

 * No regression, it is a trivial change with no behavioural change.

[Other Info]

* Upstream:
Patch has been submitted upstream (ML :<email address hidden>)
- AFAIK, there is no upstream bug database, so no URL available, ML only.
- Patch will be merge in upstream version 1.6.2 # See comment #4

* Debian bug :
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857051

[Eric Desrochers (slashd)]

Patch has been submitted to Debian

[Eric Desrochers (slashd)]

Xenial debdiff

[Eric Desrochers (slashd)]

Message from makedumpfile maintainer :

"
Hello Eric,

Thanks, I'll merge this fix into v1.6.2.

P.S. I fixed other typos on this occasion.

Regards,
Atsushi Kumagai
"

- Eric

[Eric Desrochers (slashd)]

Zesty debdiff

[Eric Desrochers (slashd)]

Debian bug :
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857051

[Brian Murray (brian-murray)]

For the record, I don't think this is worth SRU'ing to a stable release unless it is bundled with other non-typo fixes.

[Eric Desrochers (slashd)]

For the record, the change has been merge in makedumpfile upstream:

--
commit ade8512bd2be9eef9f2a0376b41f22d5417c72f3
Author: Eric Desrochers <email address hidden>
Date: Wed Mar 8 09:45:02 2017 +0900

    [PATCH] Fix typo in the ERRMSG of function show_mem_usage

    Should be "kernel" instead of "kenrel".

    Signed-off-by: Eric Desrochers <email address hidden>
--