pcbnew: Edit->Swap Layers doesn't swap text

[Eldar Khayrullin]

Application: pcbnew
Version: no-vcs-found-541b91f~58~ubuntu16.10.1, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.50.1 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.33 librtmp/2.3
Platform: Linux 4.8.0-40-generic x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.61.0
Curl: 7.50.1
KiCad - Compiler: GCC 6.2.0 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  KICAD_SCRIPTING_ACTION_MENU=ON
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_OCE=ON

[Maciej Suminski (orsonmmz)]

Swapping text layer does not work in any of the canvases. GAL needs to refresh the view after swap layer execution.

[Jeff Young (jeyjey)]

None of them do anything at all for me (text, pads, module outlines, etc.).

Did this use to work? Has it never worked? Should we remove it from the menus?

[Wayne Stambaugh (stambaughw)]

Are you using the modern canvas? It appears to work in the legacy
canvas although footprint silkscreen layers do not appear to swap
correctly. It may be one of those tools that never got ported to the
new tool framework.

On 2/19/2018 10:08 AM, Jeff Young wrote:
> None of them do anything at all for me (text, pads, module outlines,
> etc.).
>
> Did this use to work? Has it never worked? Should we remove it from
> the menus?
>
> ** Changed in: kicad
> Importance: Undecided => Medium
>

[Jeff Young (jeyjey)]

Yeah, it does sort of work on Legacy... except there's no undo. :O

Dare we remove it from the menu for 5.0?

[jean-pierre charras (jp-charras)]

I am thinking this dialog should be modified (rewritten) to allow swapping of tracks (and vias) only, only on copper layers.

The purpose of this dialog is to modify track layers when changing the number of copper layers of a board.

For instance, using 8 layers instead of 6 layers in a partially routed board often imply moving the inner 4 layer to inner 6 layers (this is especially true if you are using microvias, or if you want to create a new copper plane)

[Wayne Stambaugh (stambaughw)]

@JP, I know that this will simplify things but I can think of use cases
where the user would want to swap graphical items on other layers.
Limiting the swap to just copper layers seems a bit restrictive and I'm
guessing some users would prefer to use this feature rather than
manually changing the layer for each item on a layer.

On 3/7/2018 2:05 AM, jean-pierre charras wrote:
> I am thinking this dialog should be modified (rewritten) to allow
> swapping of tracks (and vias) only, only on copper layers.
>
> The purpose of this dialog is to modify track layers when changing the
> number of copper layers of a board.
>
> For instance, using 8 layers instead of 6 layers in a partially routed
> board often imply moving the inner 4 layer to inner 6 layers (this is
> especially true if you are using microvias, or if you want to create a
> new copper plane)
>

[Jeff Young (jeyjey)]

The new Edit Text and Graphics Properties dialog allows for moving graphics and text between layers, so we can probably simplify Swap Layers as JP suggests.

[Jeff Young (jeyjey)]

Fixed swapping of Text and Zones.
Fixed undo.
Limited dialog to copper layers.
Reimplemented dialog based on WX_GRID and PCB_LAYER_BOX_SELECTOR.

[KiCad Janitor (kicad-janitor)]

Fixed in revision d016238c82e2a7a731435e78ba41612e8f3c4899
https://git.launchpad.net/kicad/patch/?id=d016238c82e2a7a731435e78ba41612e8f3c4899