evince should display CSD headerbars for budgie-desktop

[fossfreedom]

budgie-desktop should display GNOME based CSD headerbars.

Due to the patching, it displays non GNOME based menus.

Attached is a patch to resolve this. It has been tested on multiple desktop environments;

It correctly displays a traditional menu bar for Unity.

For both GNOME-Shell and budgie-desktop CSD is displayed.

Note - I have taken the clean and consistent approach as the patching for gedit.

The extant traditional and unity patches are confused - DESKTOP_SESSION comparison is hard-coded for GNOME - budgie-desktop uses the DESKTOP_SESSION of BUDGIE:GNOME. The traditional menu bar patch is inconsistent and uses a completely different algorithm that doesnt work with budgie-desktop.

I have simplified the logic to just apply CSD for GNOME based desktops as per gedit patching.

[fossfreedom (fossfreedom)]

jbicha requested a merge proposal against lp:~ubuntu-desktop/evince/ubuntu so have created a branch as well

[Jeremy Bícha (jbicha)]

Oops, I didn't see this bug before I uploaded.

https://launchpad.net/ubuntu/+source/evince/3.22.1-3ubuntu1

You are welcome to add a debian/changelog entry (but leave release as UNRELEASED) when proposing merges for ubuntu-desktop packaging.