PrePuppet/PreConfig duplication leads to confusion
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
Medium
|
Carlos Camacho |
Bug Description
I've been asked why we have the *PreConfig interfaces for each role, as they are unused and duplicate (from an operator perspective) the ExtraConfigPre hooks we already documented.
However looking at the history, this is a mistake, as they were intended to be internal interfaces, but we reverted back to the old PrePuppet naming by mistake:
Here, I removed the *PrePuppet interfaces, replacing them with per-role
*PreConfig interfaces (intended to do the same thing but be an
implementation agnostic name):
https:/
However here, we've re-introduced it:
https:/
And here we generate it for all roles:
https:/
Effectively we've reverted my original renaming, which leaves the
*PreConfig interface unused - this isn't intended for users really
(although clearly they could use it right now), so we need to decide how to
proceed (I'd vote to deprecate and remove *PrePuppet and move to the
*PreConfig, since we've never documented *PreConfig as a user-interface).
Changed in tripleo: | |
status: | New → Triaged |
milestone: | none → pike-1 |
importance: | Undecided → Medium |
Changed in tripleo: | |
assignee: | nobody → Carlos Camacho (ccamacho) |
Changed in tripleo: | |
status: | Triaged → In Progress |
Changed in tripleo: | |
milestone: | pike-1 → pike-2 |
Fix proposed in: https:/ /review. openstack. org/#/c/ 452734/