hard to tell when the package is not actually installed with the norpm provider

[Alex Schultz]

If the norpm provider is used via OS::TripleO::Services::TripleoPackages and a package is not actually isntalled, puppet will still attempt to 'install' it but will usually fail for some other reason. We should throw a warning if the norpm provider is used and an install is actually attempted so we can identify the situations where puppet is trying to install a package but won't due to the norpm provider.

As an example,
http://logs.openstack.org/95/440795/1/check/gate-tripleo-ci-centos-7-scenario002-multinode-upgrades-nv/d7f8544/logs/postci.txt.gz#_2017-03-02_21_50_26_000

In this case, the upgrade process uses norpm but if the upgrade scripts missed installing the nova-placement-api package. Puppet indicated it tried to install it, but the apache setup failed because the file was not actually there.

Notice: /Stage[main]/Nova::Wsgi::Apache_placement/Nova::Generic_service[placement-api]/Package[nova-placement-api]/ensure: created
...
Error: /Stage[main]/Nova::Wsgi::Apache_placement/Openstacklib::Wsgi::Apache[placement_wsgi]/File[placement_wsgi]: Could not evaluate: Could not retrieve information from environment production source(s) file:/usr/bin/nova-placement-api

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/441212

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/441212
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=2be36167fd223d95a71d557afa9d26bf950e21c8
Submitter: Jenkins
Branch: master

commit 2be36167fd223d95a71d557afa9d26bf950e21c8
Author: Alex Schultz <email address hidden>
Date: Fri Mar 3 09:21:59 2017 -0700

    Throw warnings for norpm actions

    If the norpm provider attempts to do any install/update/remove actions,
    we should throw a warning in the logs so people are aware that the
    action did not actually take place.

    Change-Id: Ieee5cac3412c709ba6b39316e455d7708cc9d22e
    Closes-Bug: #1669666

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/443371

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/443371
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8a5301685bc1122d46f071f798c4d9d628cc1e92
Submitter: Jenkins
Branch: stable/ocata

commit 8a5301685bc1122d46f071f798c4d9d628cc1e92
Author: Alex Schultz <email address hidden>
Date: Fri Mar 3 09:21:59 2017 -0700

    Throw warnings for norpm actions

    If the norpm provider attempts to do any install/update/remove actions,
    we should throw a warning in the logs so people are aware that the
    action did not actually take place.

    Change-Id: Ieee5cac3412c709ba6b39316e455d7708cc9d22e
    Closes-Bug: #1669666
    (cherry picked from commit 2be36167fd223d95a71d557afa9d26bf950e21c8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 6.4.0 release.