task_deploy: no implicit conversion of String into Integer

[Vladimir Sharshov]

Detailed bug description:

If critical node is offline then deployment was started, we will get error "Error running RPC method task_deploy: no implicit conversion of String into Integer, trace: "

Steps to reproduce:

1. Create cluster with 1 controller
2. Run provision
3. Run deploy
4. Go into the controller node and stop mcollective (`service mcollective stop`)

Expected results:

Deployment failed with error: "Error running RPC method task_deploy: Critical nodes are not available for deployment: ["2"]"

Actual result:

Deployment failed with error: "no implicit conversion of String into Integer.\nInspect Astute logs for the details"

Reproducibility:

Always

Workaround:

No

Impact:

Deployment still failed but error about conversion hide real reason of fail: critical nodes are not available for deployment

Description of the environment:

Fuel 9 or higher.

Additional information:

2017-03-02 15:16:19 INFO [23014] Casting message to Nailgun:
{"method"=>"transaction_resp",
 "args"=>
  {"task_uuid"=>"d11c0b69-9f63-4e6b-a321-cfeb5b51f210", "status"=>"running"}}
2017-03-02 15:16:19 INFO [23014] Processing RPC call 'task_deploy'
2017-03-02 15:16:19 INFO [23014] Task based deployment will be used
2017-03-02 15:16:19 INFO [23014] Check inpute data file /var/lib/astute/graphs/graph-d11c0b69-9f63-4e6b-a321-cfeb5b51f210.yaml
2017-03-02 15:18:09 WARNING [23014] Offline node ["2"]
2017-03-02 15:18:09 WARNING [23014] Validation of node:
{"uid"=>"2",
 "error_msg"=>"Node is not ready for deployment: mcollective has not answered",
 "status"=>"error"}
 for report failed: Task status provided '' is not supported; Task name is not provided
2017-03-02 15:18:09 INFO [23014] Deployment summary: time was spent 00:01:50
2017-03-02 15:18:09 ERROR [23014] Error running RPC method task_deploy: no implicit conversion of String into Integer, trace:
["/usr/share/gems/gems/astute-10.0.0/lib/astute/task_deployment.rb:304:in `[]'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/task_deployment.rb:304:in `block in critical_node_uids'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/task_deployment.rb:303:in `each'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/task_deployment.rb:303:in `inject'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/task_deployment.rb:303:in `critical_node_uids'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/task_deployment.rb:326:in `fail_offline_nodes'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/task_deployment.rb:110:in `create_cluster'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/task_deployment.rb:143:in `deploy'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/orchestrator.rb:63:in `task_deploy'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/dispatcher.rb:88:in `task_deploy'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/server.rb:172:in `dispatch_message'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/server.rb:131:in `block in dispatch'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/task_queue.rb:64:in `call'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/task_queue.rb:64:in `block in each'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/task_queue.rb:56:in `each'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/task_queue.rb:56:in `each'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/server.rb:128:in `each_with_index'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/server.rb:128:in `dispatch'",
 "/usr/share/gems/gems/astute-10.0.0/lib/astute/server/server.rb:106:in `block in perform_main_job'"]
2017-03-02 15:18:09 INFO [23014] Casting message to Nailgun:
{"method"=>"transaction_resp",
 "args"=>
  {"task_uuid"=>"d11c0b69-9f63-4e6b-a321-cfeb5b51f210",
   "nodes"=>
    [{"uid"=>"2",
      "error_msg"=>
       "Node is not ready for deployment: mcollective has not answered",
      "status"=>"error"}],
   "error"=>"Node is not ready for deployment"}}
2017-03-02 15:18:09 INFO [23014] Casting message to Nailgun:
{"method"=>"transaction_resp",
 "args"=>
  {"task_uuid"=>"d11c0b69-9f63-4e6b-a321-cfeb5b51f210",
   "status"=>"error",
   "error"=>
    "Method task_deploy. no implicit conversion of String into Integer.\nInspect Astute logs for the details"}}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/440666

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/440666
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=892894bfb534277642d91ad130515ca8465de582
Submitter: Jenkins
Branch: master

commit 892894bfb534277642d91ad130515ca8465de582
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Thu Mar 2 19:16:31 2017 +0300

    task_deploy: no implicit conversion of String into Integer

    Now Astute will not calculate fault tolerance groups and
    critical node uids twice.

    Change-Id: I3bf2dd0ffc0fc74fd9c670bd50b32e3285ae7e2a
    Closes-Bug: #1669499

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/442524

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/442526

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/442526
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=29988c78e98b6026b1315ea710938298d0d93b0f
Submitter: Jenkins
Branch: stable/newton

commit 29988c78e98b6026b1315ea710938298d0d93b0f
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Thu Mar 2 19:16:31 2017 +0300

    task_deploy: no implicit conversion of String into Integer

    Now Astute will not calculate fault tolerance groups and
    critical node uids twice.

    Change-Id: I3bf2dd0ffc0fc74fd9c670bd50b32e3285ae7e2a
    Closes-Bug: #1669499
    (cherry picked from commit 892894bfb534277642d91ad130515ca8465de582)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/445418

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/445418
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=fcb333bb5b97c2b3098fdba22677c3a5ebd562d2
Submitter: Jenkins
Branch: stable/ocata

commit fcb333bb5b97c2b3098fdba22677c3a5ebd562d2
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Thu Mar 2 19:16:31 2017 +0300

    task_deploy: no implicit conversion of String into Integer

    Now Astute will not calculate fault tolerance groups and
    critical node uids twice.

    Change-Id: I3bf2dd0ffc0fc74fd9c670bd50b32e3285ae7e2a
    Closes-Bug: #1669499
    (cherry picked from commit 892894bfb534277642d91ad130515ca8465de582)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/mitaka
Review: https://review.opendev.org/442524
Reason: This repo is retired now, no further work will get merged.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-astute ocata-eol release.