N->O upgrade with a ceph osd node fails.

[Sofer Athlan-Guyot]

Running a upgrade with 3controller/1ceph/2compute fails during composable_upgrade:

017-03-01 12:02:31Z [overcloud-ControllerServiceChain-odphgohyyarx-ServiceChain-6qa6bwq7rpzd.3]: DELETE_IN_PROGRESS state changed
2017-03-01 12:02:32Z [overcloud-ControllerServiceChain-odphgohyyarx-ServiceChain-6qa6bwq7rpzd.16]: DELETE_IN_PROGRESS state changed
2017-03-01 12:02:38Z [overcloud-ControllerServiceChain-odphgohyyarx]: UPDATE_COMPLETE Stack UPDATE completed successfully
2017-03-01 12:02:38Z [ControllerServiceChain]: UPDATE_COMPLETE state changed
2017-03-01 12:02:39Z [CephStorage]: UPDATE_IN_PROGRESS state changed
2017-03-01 12:02:41Z [CephStorage]: UPDATE_FAILED StackValidationFailed: resources.CephStorage: Property error: Properties.resource_def: Error in ControllerServiceChain output role_data: Error in 18 output role_data: The Parameter (NovaPassword) was not provided.
2017-03-01 12:02:41Z [overcloud]: UPDATE_FAILED StackValidationFailed: resources.CephStorage: Property error: Properties.resource_def: Error in ControllerServiceChain output role_data: Error in 18 output role_data: The Parameter (NovaPassword) was not provided.

[Giulio Fidente (gfidente)]

NovaPassword does not seem to be consumed by the services/ceph*yaml files; strange it says:

  StackValidationFailed: resources.CephStorage: Property error: Properties.resource_def: Error in ControllerServiceChain output role_data: Error in 18 output role_data: The Parameter (NovaPassword) was not provided.

as if validation failed on CephStorage for a missing property in the ControllerServiceChain output

[Giulio Fidente (gfidente)]

Seems like we're not passing NovaPassword to the upgrade step, probably introduced with ed220aecf5ce45d50896054fd3dc2216bcffce20

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

As Guilio guessed it, it was a missing NovaPassword in another template that triggered the error. It points to Ceph only because it's the first lexically speaking in the templates to be validated.

Fixing the associated review https://review.openstack.org/#/c/439095/1/puppet/services/pacemaker/database/mysql.yaml and closing this bug.