nova boot api raises ValueError when incorrect formatted metadata is passed

[Dinesh Bhor]

If you pass incorrect formatted metadata to the 'boot', 'rebuild' and 'image-create'
apis returns following error:

ERROR (ValueError): dictionary update sequence element #0 has length 1; 2 is required

The above error message is not user friendly. It doesn't give proper information to user to change the input accordingly.

Command:
nova boot --image <image-id> --flavor 1 --meta HA_Enabled,qad <instance_name>

Output:
ERROR (ValueError): dictionary update sequence element #0 has length 1; 2 is required

The metdata(--meta) should be in key=value pair.

The same issue is there for 'image-create' and 'rebuild' apis.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/441750

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/444343

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/441750
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=72a0ec9adcd19a96644638e8324566fcc4af8799
Submitter: Jenkins
Branch: master

commit 72a0ec9adcd19a96644638e8324566fcc4af8799
Author: Dinesh Bhor <email address hidden>
Date: Tue Feb 14 13:10:33 2017 +0530

    Fix ValueError when incorrect metadata passed

    If you pass incorrect formatted metadata to the 'boot', 'rebuild'
    and 'image-create' apis returns following error:

    ERROR (ValueError): dictionary update sequence element #0 has
    length 1; 2 is required

    Caught the ValuError and raised argparse.ArgumentTypeError with
    proper error message.

    Closes-Bug: #1668549
    Change-Id: I14a30b93f4a916fc04610f9e475c12eb352e38c5

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-novaclient 8.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444343
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=b535bbd6831a9747b0b71a9031b1149b48292a94
Submitter: Jenkins
Branch: stable/ocata

commit b535bbd6831a9747b0b71a9031b1149b48292a94
Author: Dinesh Bhor <email address hidden>
Date: Tue Feb 14 13:10:33 2017 +0530

    Fix ValueError when incorrect metadata passed

    If you pass incorrect formatted metadata to the 'boot', 'rebuild'
    and 'image-create' apis returns following error:

    ERROR (ValueError): dictionary update sequence element #0 has
    length 1; 2 is required

    Caught the ValuError and raised argparse.ArgumentTypeError with
    proper error message.

    Closes-Bug: #1668549
    Change-Id: I14a30b93f4a916fc04610f9e475c12eb352e38c5
    (cherry picked from commit 72a0ec9adcd19a96644638e8324566fcc4af8799)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-novaclient 7.1.1 release.