Use "target" url in redfish standard instead of hardcode

Bug #1668434 reported by Lin Yang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sushy
Fix Released
High
Lin Yang

Bug Description

Current when resetting power state of the computer system, it generate URL with hard coded address '/Actions/ComputerSystem.Reset'.
https://github.com/openstack/sushy/blob/ec200bb3c00aa8caa1104d08560fd448b4bab37c/sushy/resources/system/system.py#L147

Actually redfish standard contains "target" URL for each action, should use it instead of hard code.

  "Actions" : {
    "#ComposedNode.Reset" : {
      "target" : "/redfish/v1/Nodes/2/Actions/ComputerSystem.Reset",
      "<email address hidden>" : [ "On", "ForceOff", "GracefulShutdown", "ForceRestart", "Nmi", "GracefulRestart", "ForceOn", "PushPowerButton" ]
    }
  }

Lin Yang (lin-a-yang)
Changed in sushy:
assignee: nobody → Lin Yang (lin-a-yang)
Changed in sushy:
status: New → Triaged
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sushy (master)

Fix proposed to branch: master
Review: https://review.openstack.org/440822

Changed in sushy:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sushy (master)

Reviewed: https://review.openstack.org/440822
Committed: https://git.openstack.org/cgit/openstack/sushy/commit/?id=0165d26672c7c3f22105231add37876119c62616
Submitter: Jenkins
Branch: master

commit 0165d26672c7c3f22105231add37876119c62616
Author: Lin Yang <email address hidden>
Date: Thu Mar 2 13:42:35 2017 -0800

    Fix hardcoded reset system path

    Previously, the path of resetting system is hardcoded to
    '/Actions/ComputerSystem.Reset'. Actually redfish provide 'target'
    attribution for each action. So use it instead of hardcode.

    Change-Id: Id5aaa418ff5ffc693afc593db5c4dc852b5b6c33
    Closes-Bug: #1668434

Changed in sushy:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.