Settings dialog crashes with Japanese fonts

[m4984]

I'm on Arch Linux and have the Google Noto fonts as default system fonts. In the preferences window on the tab 'Card appearance' when I click on 'Preview' or 'OK' the dialog crashes with the following error message:

###---

An unexpected error has occurred.
Please forward the following info to the developers:

Traceback (innermost last):
  File "/usr/lib/python3.6/site-packages/mnemosyne/pyqt_ui/configuration_wdgt_card_appearance.py", line 211, in preview
    render_chain.renderer_for_card_type(card_type).update(card_type)
  File "/usr/lib/python3.6/site-packages/mnemosyne/libmnemosyne/renderers/html_css.py", line 94, in update
    self.card_type_css(card_type, **render_args)
  File "/usr/lib/python3.6/site-packages/mnemosyne/libmnemosyne/renderers/html_css.py", line 71, in card_type_css
    family,size,x,x,w,i,u,s,x,x = font_string.split(",")
 ValueError: too many values to unpack (expected 10)

###---

Since I use these fonts as system default they are the default option in Mnemosyne as well. Took me a while to figure out that the fonts were the culprit...

[Peter Bienstman (peter-bienstman)]

Could you put a print(font_string) statement in html_css.py at line 71 and let me know the output? If you don't feel comfortable tinkering in the source, I can also send you a link to a debug version.

[m4984 (m4984)]

I'm not a coder so if you can send me either just the modified html_css.py file or a screenshot or code tag of how the modified file should look like, I'm more than happy to help.

I do get this error with all Japanese fonts btw. not just Noto.

[m4984 (m4984)]

This is the current file:

 67 # Font.
 68 font_string = self.config().card_type_property(\
 69 "font", card_type, proxy_fact_key)
 70 if font_string:
 71 family,size,x,x,w,i,u,s,x,x = font_string.split(",")
 72 css += "font-family: \"%s\"; " % family
 73 css += "font-size: %spt; " % size
 74 if w == "25":
 75 css += "font-weight: light; "
 76 if w == "75":
 77 css += "font-weight: bold; "
 78 if i == "1":
 79 css += "font-style: italic; "
 80 if i == "2":
 81 css += "font-style: oblique; "
 82 if u == "1":
 83 css += "text-decoration: underline; "
 84 if s == "1":
 85 css += "text-decoration: line-through; "
 86 css += "}\n"
 87 return css

[m4984 (m4984)]

Think I figured it out. So this is the output:

Traceback (innermost last):
  File "/usr/lib/python3.6/site-packages/mnemosyne/pyqt_ui/configuration_wdgt_card_appearance.py", line 211, in preview
    render_chain.renderer_for_card_type(card_type).update(card_type)
  File "/usr/lib/python3.6/site-packages/mnemosyne/libmnemosyne/renderers/html_css.py", line 95, in update
    self.card_type_css(card_type, **render_args)
  File "/usr/lib/python3.6/site-packages/mnemosyne/libmnemosyne/renderers/html_css.py", line 72, in card_type_css
    family,size,x,x,w,i,u,s,x,x = font_string.split(",")
 ValueError: too many values to unpack (expected 10)
XmbTextListToTextProperty result code -2
XmbTextListToTextProperty result code -2
XmbTextListToTextProperty result code -2
Noto Sans [GOOG],12,-1,5,50,0,0,0,0,0,Regular
An unexpected error has occurred.
Please forward the following info to the developers:

Traceback (innermost last):
  File "/usr/lib/python3.6/site-packages/mnemosyne/pyqt_ui/configuration_dlg.py", line 54, in accept
    self.tab_widget.widget(index).apply()
  File "/usr/lib/python3.6/site-packages/mnemosyne/pyqt_ui/configuration_wdgt_card_appearance.py", line 206, in apply
    update(card_type)
  File "/usr/lib/python3.6/site-packages/mnemosyne/libmnemosyne/renderers/html_css.py", line 95, in update
    self.card_type_css(card_type, **render_args)
  File "/usr/lib/python3.6/site-packages/mnemosyne/libmnemosyne/renderers/html_css.py", line 72, in card_type_css
    family,size,x,x,w,i,u,s,x,x = font_string.split(",")
 ValueError: too many values to unpack (expected 10)
XmbTextListToTextProperty result code -2
XmbTextListToTextProperty result code -2
XmbTextListToTextProperty result code -2
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,16,-1,5,50,0,0,0,0,0
Sans Serif,1...

[m4984 (m4984)]

It's the 'Regular' part of 'Noto Sans [GOOG],12,-1,5,50,0,0,0,0,0,Regular' that causes the error, I guess?

[m4984 (m4984)]

Ok, throwing out the last string value works for me as a workaround:

Added:

if len(font_string.split(",")) == 11:
    a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, a11 = font_string.split(",")
    font_string = a1 + "," + a2 + "," + a3 + "," + a4 + "," + a5 + "," + a6 + "," + a7 + "," + a8 + "," + a9 + "," + a10

in line 70 in html_css.py and in line 43 in html_css_card_browser.py

works for me now

[Peter Bienstman (peter-bienstman)]

For not being a coder you did a great job fixing this bug! Thanks, I'll add this to the next release.

[m4984 (m4984)]

Haha, thanks. Python was pretty verbose. Just had to fight a bit with the syntax (where I got a bit of help from a friend) and indentation...
Thank you for the quick reply and great job with the program!

[m4984 (m4984)]

just realized that I can't sync to android anymore, since the android client now throws the same error ;)

[Peter Bienstman (peter-bienstman)]

Try this version:

https://www.dropbox.com/s/j5ze1y894kmkfrd/app-release.apk?dl=0

[m4984 (m4984)]

works beautifully. thank you!