V2 role create does not allow spaces in the role description

Bug #1667367 reported by Guang Yee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Undecided
Tin Lam

Bug Description

Creating a new role using V2 APIs no longer allow spaces in the role description. Looks like it was broken since the introduction of JSON schema. See

https://github.com/openstack/keystone/blob/master/keystone/assignment/schema.py#L20

Instead of parameter_types.id_string. It should be:
parameter_types.description.

Gage Hugo (gagehugo)
Changed in keystone:
status: New → Confirmed
Revision history for this message
Gage Hugo (gagehugo) wrote :

Hey Guang,

It looks like the v2 validation tests are using the v3 schema by accident, we will get this fixed asap!

Changed in keystone:
assignee: nobody → Gage Hugo (gagehugo)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/437797

Changed in keystone:
assignee: Gage Hugo (gagehugo) → Tin Lam (tl3438)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/437797
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=eb535ca4768f20184db4885abec75996ffdeda0c
Submitter: Jenkins
Branch: master

commit eb535ca4768f20184db4885abec75996ffdeda0c
Author: Tin Lam <email address hidden>
Date: Thu Feb 23 23:38:32 2017 -0600

    Fix v2 role create schema validation

    Currently, creating a new role using the v2 api no longer allows
    spaces in the role description. This patch set changes the
    schema type, and also fixes a bug in the v2 validation test where
    the validation is performed against the v3 schema instead of v2.

    Co-Authored-By: Gage Hugo <email address hidden>

    Change-Id: I858005c7805ba87f506933d49715cc3ce0d539e1
    Closes-Bug: #1667367

Changed in keystone:
status: In Progress → Fix Released
Changed in keystone:
milestone: none → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 12.0.0.0b1

This issue was fixed in the openstack/keystone 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.