Evergreen

SIP always returns USD as patron currency type

Bug #1667221 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.12.2
2.11
Fix Released
Medium
Unassigned
Evergreen 2.11.5

Bug Description

In all supported versions of Evergreen, the SIP module always returns "USD" as the patron currency type (the BH field in various SIP responses). Since each library has a currency defined in implementation_config section of the SIP config file, I propose we return the library's currency value instead.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1667221-sip-currency has this simple fix:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=b7f60f0

tags: added: sip
tags: added: pullrequest
Jeff Davis (jdavis-sitka)
Changed in evergreen:
milestone: none → 2.12.1
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.12.1 → 2.12.2
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

Tested and signed off (with a small follow-up patch). Signoff branch is user/gmcharlt/lp1667221_signoff.

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_2_12, and rel_2_11. Thanks, Jeff!

Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.