undercloud install does not exit with a return code of 1 when an error occurs

[Alex Schultz]

We're not properly returning 1 when a failure occurs.

[centos@undercloud ~]$ openstack undercloud install
2017-02-22 22:01:00,220 INFO: Logging to /home/centos/.instack/install-undercloud.log
2017-02-22 22:01:00,243 INFO: Checking for a FQDN hostname...
2017-02-22 22:01:00,293 INFO: Static hostname detected as undercloud.localdomain
2017-02-22 22:01:00,314 INFO: Transient hostname detected as undercloud.localdomain
2017-02-22 22:01:00,317 ERROR: Undercloud configuration validation failed: undercloud_public_host "8.43.87.235" not in defined CIDR "192.168.24.0/24"
2017-02-22 22:01:00,317 ERROR:
#############################################################################
Undercloud install failed.

Reason: undercloud_public_host "8.43.87.235" not in defined CIDR "192.168.24.0/24"

See the previous output for details about what went wrong. The full install
log can be found at /home/centos/.instack/install-undercloud.log.

#############################################################################

[centos@undercloud ~]$ echo $?
0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/437172

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/437172
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=a620d4d0f0aa950ffb6f89209f8e1fec94b1684d
Submitter: Jenkins
Branch: master

commit a620d4d0f0aa950ffb6f89209f8e1fec94b1684d
Author: Alex Schultz <email address hidden>
Date: Wed Feb 22 15:07:18 2017 -0700

    Return 1 when an error occurs

    We need to make sure that we return 1 when we get an exception in the
    install/upgrade process.

    Change-Id: I3aefe7b93fa168483361542f1ef55646094efd38
    Closes-Bug: #1667136

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/438181

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/438181
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=56bf79546621f51ee96c9dab2825bf9ee3838c1d
Submitter: Jenkins
Branch: stable/ocata

commit 56bf79546621f51ee96c9dab2825bf9ee3838c1d
Author: Alex Schultz <email address hidden>
Date: Wed Feb 22 15:07:18 2017 -0700

    Return 1 when an error occurs

    We need to make sure that we return 1 when we get an exception in the
    install/upgrade process.

    Change-Id: I3aefe7b93fa168483361542f1ef55646094efd38
    Closes-Bug: #1667136
    (cherry picked from commit a620d4d0f0aa950ffb6f89209f8e1fec94b1684d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 6.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 7.0.0.0b1 development milestone.