Incorrect condition for create_network_postcommit

Bug #1666352 reported by Takanori Miyagishi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-fujitsu
Fix Released
High
Takanori Miyagishi

Bug Description

fossw mechanism driver judges to run create_network_postcommit or not.
But the condition is incorrect.

Current condition is here:
        if (provider_type == 'vlan' and segmentation_id and
           not fj_util.is_baremetal(mech_context.current)):
            self.create_network_postcommit_vlan(segmentation_id)

Actually, the method should be called with regardless baremetal or not.

Changed in networking-fujitsu:
assignee: nobody → Takanori Miyagishi (miyagishi-t)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-fujitsu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/451222

Changed in networking-fujitsu:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-fujitsu (master)

Reviewed: https://review.openstack.org/451222
Committed: https://git.openstack.org/cgit/openstack/networking-fujitsu/commit/?id=7bf647dd32d3acbcfbb60d79e0d7e851b75dbfd4
Submitter: Jenkins
Branch: master

commit 7bf647dd32d3acbcfbb60d79e0d7e851b75dbfd4
Author: takanorimiyagishi <email address hidden>
Date: Wed Mar 29 15:48:44 2017 +0900

    Fix conditions for create vlan on FOS switch

    Remove a condition that judging whether port's type is baremetal or not
    to handle create_vlan. There is no port information at the timing of create
    network, therefore the condition is meaningless.

    Change-Id: I178c22624e68335f0b39da23886af4749b801eae
    Closes-Bug: #1666352

Changed in networking-fujitsu:
status: In Progress → Fix Released
Changed in networking-fujitsu:
milestone: none → 4.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-fujitsu (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/453097

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-fujitsu (stable/ocata)

Reviewed: https://review.openstack.org/453097
Committed: https://git.openstack.org/cgit/openstack/networking-fujitsu/commit/?id=8f5de49c6a44a9127b6a9e3da3e3de8053f7626a
Submitter: Jenkins
Branch: stable/ocata

commit 8f5de49c6a44a9127b6a9e3da3e3de8053f7626a
Author: takanorimiyagishi <email address hidden>
Date: Wed Mar 29 15:48:44 2017 +0900

    Fix conditions for create vlan on FOS switch

    Remove a condition that judging whether port's type is baremetal or not
    to handle create_vlan. There is no port information at the timing of create
    network, therefore the condition is meaningless.

    Change-Id: I178c22624e68335f0b39da23886af4749b801eae
    Closes-Bug: #1666352
    (cherry picked from commit 7bf647dd32d3acbcfbb60d79e0d7e851b75dbfd4)

tags: added: in-stable-ocata
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.