Deployment has failed with "undefined method `[]' for nil:NilClass at netconfig.pp:24"

[Alexander Rubtsov]

--- Environment ---
MOS: 9.0 + code from stable/mitaka branch on January 22, 2017
Fuel-library: 9.0-9.0.0-1.mos8727
Features: DPDK, Reduced Footprint, Network template with bondings and VLANs

--- Description ---
Deployment fails every time while the following commit is in place:
https://review.openstack.org/#/c/423390/
If the changes introduced by this commit are disabled, the deployment finishes well

--- Steps to reproduce ---
1) Configure a new environment according to the "Environment" settings above
2) Start the deployment

--- Actual result ---
The deployment has failed.
notice: (Scope(Class[Osnailyfacter::Netconfig::Netconfig])) MODULAR: netconfig/netconfig.pp
err: undefined method `[]' for nil:NilClass at /etc/puppet/modules/osnailyfacter/manifests/netconfig/netconfig.pp:24 on node compute-0-5.domain.tld
err: /etc/puppet/modules/l23network/lib/puppet/parser/functions/generate_network_config.rb:350:in `block (3 levels) in <top (required)>'
err: /etc/puppet/modules/l23network/lib/puppet/parser/functions/generate_network_config.rb:326:in `each'
err: /etc/puppet/modules/l23network/lib/puppet/parser/functions/generate_network_config.rb:326:in `block (2 levels) in <top (required)>'
err: /etc/puppet/modules/l23network/lib/puppet/parser/functions/generate_network_config.rb:311:in `each'
err: /etc/puppet/modules/l23network/lib/puppet/parser/functions/generate_network_config.rb:311:in `block in <top (required)>'
http://paste.openstack.org/show/cT5V50M0ymxiUMEPemwF/

--- Expected result ---
The deployment finishes successfully

--- Additional information ---
The diagnostic snapshot from a problematic environment can be provided directly on demand

[Alexander Rubtsov (arubtsov)]

sla1 for 9.0-updates

[Sergey Vasilenko (xenolog)]

additional information was requested directly

[Alexander Rubtsov (arubtsov)]

The requested information has been provided

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/438928

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/439483

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/439484

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/439485

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/438928
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=d5fd08f78118a36a2cde8df4f5d216ca7b042bcf
Submitter: Jenkins
Branch: master

commit d5fd08f78118a36a2cde8df4f5d216ca7b042bcf
Author: Sergey Vasilenko <email address hidden>
Date: Tue Feb 28 14:34:25 2017 +0300

    Support bonds of subinterfaces while merge interface_properties

    Change-Id: I27ede232a37c4e8c2d669f5dd8936a60baf04b40
    Related-bug: #1643920
    Closes-bug: #1666229

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/439483
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a5eca380199738c5df0e497099145de0e5f5a824
Submitter: Jenkins
Branch: stable/mitaka

commit a5eca380199738c5df0e497099145de0e5f5a824
Author: Sergey Vasilenko <email address hidden>
Date: Tue Feb 28 14:34:25 2017 +0300

    Support bonds of subinterfaces while merge interface_properties

    Change-Id: I27ede232a37c4e8c2d669f5dd8936a60baf04b40
    Related-bug: #1643920
    Closes-bug: #1666229

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/439484
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b43956ce2cc129a5e9aa9c236e683a7b4a706b24
Submitter: Jenkins
Branch: stable/newton

commit b43956ce2cc129a5e9aa9c236e683a7b4a706b24
Author: Sergey Vasilenko <email address hidden>
Date: Tue Feb 28 14:34:25 2017 +0300

    Support bonds of subinterfaces while merge interface_properties

    Change-Id: I27ede232a37c4e8c2d669f5dd8936a60baf04b40
    Related-bug: #1643920
    Closes-bug: #1666229

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/439485
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=ade66c382645b8ee10bab3950fde914d4898ba8d
Submitter: Jenkins
Branch: stable/ocata

commit ade66c382645b8ee10bab3950fde914d4898ba8d
Author: Sergey Vasilenko <email address hidden>
Date: Tue Feb 28 14:34:25 2017 +0300

    Support bonds of subinterfaces while merge interface_properties

    Change-Id: I27ede232a37c4e8c2d669f5dd8936a60baf04b40
    Related-bug: #1643920
    Closes-bug: #1666229
    (cherry picked from commit d5fd08f78118a36a2cde8df4f5d216ca7b042bcf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 11.0.0.0rc2 release candidate.

[TatyanaGladysheva (tgladysheva)]

Verified on 9.2 + mu1 updates.

Environment:
MOS 9.2 + mu1, 1 controller + 1 compute nodes
Fuel-library: 9.0-9.0.0-1.mos8743
Features: DPDK, Network template with bondings and VLANs

Before the fix:
Issue is completely reproduced with network template which was adapted for my environment.

After the fix:
Deployment is finished successfully for environment with the same network template as before the fix.

[TatyanaGladysheva (tgladysheva)]

Verified on 10.0 build #1569.

Environment:
MOS 10.0, 1 controller + 1 compute nodes
Fuel-library: 10.0-10.0.0-1.mos9011
Features: DPDK, Network template with bondings and VLANs

Actual results:
Deployment is finished successfully for environment with network template which was adapted for my environment.