OpenStack Shared File Systems Service (Manila)

Wrong substitution for replica ID in logging message deleting share replica

Bug #1665635 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
NidhiMittalHada
OpenStack Shared File Systems Service (Manila) pike-3 "P-3"

Bug Description

Code at [1] uses wrong value for substitution of share replica ID. Now it uses built-in "id", but should do "share_replica['id']". For the moment we see following in manila-api logs:

"""
2017-02-13 12:00:13.427 7537 INFO manila.share.api [req-af6cf1d9-b2e6-439b-b193-6776e4c8e5aa - - - - -] Deleting replica <built-in function id>.
"""

[1] https://github.com/openstack/manila/blob/15b27e8f/manila/share/api.py#L527

Tags: api
Valeriy Ponomaryov (vponomaryov)
Changed in manila:
importance: Undecided → Low
milestone: none → pike-1
tags: added: api
NidhiMittalHada (nidhimittal19)
Changed in manila:
assignee: nobody → NidhiMittalHada (nidhimittal19)
NidhiMittalHada (nidhimittal19)
Changed in manila:
status: New → In Progress
Revision history for this message
NidhiMittalHada (nidhimittal19) wrote :

working on this

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/475231

Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: pike-1 → pike-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/475231
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ef8bb2e1499140225875a8d78cde5e5358d35f9c
Submitter: Jenkins
Branch: master

commit ef8bb2e1499140225875a8d78cde5e5358d35f9c
Author: nidhimittalhada <email address hidden>
Date: Mon Jun 19 10:47:55 2017 +0530

    Wrong substitution of replica ID in log message

    Its noted that we are using wrong value for substitution
    of share replica ID in delete share replica api code.

    For that, Wrong id is logged in manila-api logs.
    Corrected it.

    Change-Id: I6049692d9ea4570704bdb3e4171d50c95515ac7d
    Closes-Bug: #1665635

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 5.0.0.0b3

This issue was fixed in the openstack/manila 5.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.