resource object always loads properties data

[Crag Wolfe]

Every time a resource object is loaded, an additional db query is made to load its resource_properties_data, if any. Certainly, there are cases where we don't care about the properties_data, e.g. describe_stack_resources.

For those cases we are sure we need the properties data, it ought to be eager loaded instead.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/447843

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/447843
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=705625cee79a566ad5f13b0969a5b2b58f118987
Submitter: Jenkins
Branch: master

commit 705625cee79a566ad5f13b0969a5b2b58f118987
Author: Crag Wolfe <email address hidden>
Date: Tue Mar 21 01:52:50 2017 -0400

    Eager load resource_properties_data in resource

    Eager load resource_properties_data in resources in the typical
    resource-loading scenarios where properties data will be
    accessed. Thus, we can save an extra db query per resource when
    loading all the resources in a stack, for instance. Fall back to lazy
    loading properties data in other scenarios.

    Also, the resource object doesn't need to store a copy of its
    ResourcePropertiesData object in self.rsrc_prop_data, so don't.

    Change-Id: Ib7684af3fe06f818628fd21f1216de5047872948
    Closes-Bug: #1665503

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 10.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/521643

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/521643
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=dbc852b47a9a6a1044dd2a554f16f27681dbe762
Submitter: Zuul
Branch: master

commit dbc852b47a9a6a1044dd2a554f16f27681dbe762
Author: Zane Bitter <email address hidden>
Date: Mon Nov 20 13:59:19 2017 -0500

    Eager-load properties for nested resource list

    When doing "openstack stack resource list --nested-depth=n", we were
    lazy-loading the resources' properties data. This is expensive, especially
    when there are a large number of resources. Eager-load the data, as we
    always use it to show the resources.

    For consistency, always eager-load the resource 'data' (even in
    resource_get), because the Resource versioned object accesses it
    unconditionally.

    Change-Id: Idb871fddf77bf24828878c315e19e200c28841be
    Related-Bug: #1665503