heat --include-password does not pass credentials in request

[Kashif Siddiqui]

v1.8.0 (Exists in earlier versions as well)

heat --include-pass stack-create does not pass the credentials in request headers even though ENV has os_username and os_password set.

But it does work if we disable the client auth and manually pass the auth_token
for eg. This works
heat --include-pass --os-no-client-auth --os-auth-token <SOME_VALID_TOKEN> stack-create -f template.yaml stack1

STEPS:

  NOT WORKING:
    > set OS_USERNAME and OS_PASSWORD and other stuff...
    > heat --debug --include-pass stack-create -f template.yaml stack1
  RESULT:
    No 'X-Auth-User' and 'X-Auth-Key' in request header

  WORKING:
    > heat --debug --os-no-client-auth --os-auth-token <SOME_TOKEN> --include-pass stack-create -f template.yaml stack1
  RESULT:
    'X-Auth-User' and 'X-Auth-Key' present in request header

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/435213