[FWaaS v2] Unused attribut 'firewall_policy_id' on rule resource

Bug #1665300 reported by Édouard Thuleau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Invalid
Undecided
Édouard Thuleau

Bug Description

In the FWaaS v2 API extension, an attribut named 'firewall_policy_id' was declared on the 'rule' resource [1] but it not set or used anywhere in the code. Probably a copy/paste from v1 API.

[1] https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/extensions/firewall.py#L259

Tags: fwaas
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/434815

Changed in neutron:
assignee: nobody → Édouard Thuleau (ethuleau)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-fwaas (master)

Change abandoned by Édouard Thuleau (<email address hidden>) on branch: master
Review: https://review.openstack.org/434815
Reason: This patch is still necessary but needs to be applied on neutron-lib project as FWaaS APIs definition move to that repository.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (master)

Fix proposed to branch: master
Review: https://review.openstack.org/474524

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-lib (master)

Change abandoned by boden (<email address hidden>) on branch: master
Review: https://review.openstack.org/474524
Reason: This patch hasn't been updated in over 4 weeks and therefore I'm cleaning it off the queue.

If this patch is still active please updated with a fresh version.

Thanks

Revision history for this message
Reedip (reedip-banerjee-deactivatedaccount) wrote :

This issue is invalid.
However, the lack of firewall_policy_id was fixed in https://review.openstack.org/#/c/370731/

Changed in neutron:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.